search

derhuerst / parse-gml-polygon

Convert a GML Polygon into GeoJSON.
https://github.com/derhuerst/parse-gml-polygon
ISC License
11 stars 2 forks source link

Fixes #4 #7

Closed highsource closed 6 years ago

highsource commented 6 years ago

This fixes #4, all parse-functions now have (data, opts, ctx) signature.

I've also updated the documentation.

What I didn't do is bump the version in package.json. This is a breaking change so it should be 1.x.x I guess, but I'm not sure what your policy on versions is.

Also sorry the "ignoring Eclipse project files" commits appear again. I don't know why. :(

derhuerst commented 6 years ago

Thanks!

I think we should bump the version if we already need the code in wfs-gml-to-geojson. Otherwise we could wait if more breaking changes come up.

highsource commented 6 years ago

Thanks for the review!

derhuerst commented 6 years ago

FYI I usually follow the standardjs style, omitting semicolons most of the time, but I don't care that much here.

highsource commented 6 years ago

Let's say I have some personal scores with automatic semicolon insertion. :)

But if there were some xlint style checked automatically, I'd gladly conform to it.

highsource commented 6 years ago

Please see the latest changes. I appreciate your feedback.

derhuerst commented 6 years ago

Let's say I have some personal scores with automatic semicolon insertion. :)

I can relate to that! ASI is somewhat unintuitive, which why I only insist on omitted semicolons when I have a linter catching ASI mistakes.

But if there were some xlint style checked automatically, I'd gladly conform to it.

If you wish, let's add standardjs.

Please see the latest changes.

Looks good!

highsource commented 6 years ago

If you wish, let's add standardjs.

+1 but could you please do it?

derhuerst commented 6 years ago

One more thing: Let's mark commits that break the API so we can easily see wether to increase the major version number later. I usually use the :boom: 💥 emoji, inspired by gitmoji.

highsource commented 6 years ago

I can relate to that! ASI is somewhat unintuitive, which why I only insist on omitted semicolons when I have a linter catching ASI mistakes.

I wrote a JavaScript parser a few years ago. ASI was hell, by far the most complicated thing from the whole language.