search

deric / puppet-mesos

Puppet module for managing Mesos nodes
https://forge.puppetlabs.com/deric/mesos
Apache License 2.0
69 stars 61 forks source link

options should not be prepended with 'master' or 'slave'. #67

Closed blsmth closed 8 years ago

blsmth commented 8 years ago

fixes issue reported in #66 where options stored in /etc/mesos-master and /etc/mesos-slave were being prepended with master_ and slave_ which was breaking functionality with /usr/bin/mesos-init-wrapper because it sends options as --master_hostname as opposed to hostname for instance.

i'm not sure how or why this is not affecting any other users of this module, so this code may be irrelevant and I may just be looking for clarification on why my setup is not working out of the box.

blsmth commented 8 years ago

also if I should pull against the 'dev' branch please just let me know

deric commented 8 years ago

Property prefixing was introduced in order to avoid conflicts between properties with the same name (see #45). This patch would break such behavior, we have to find a better way how to fix this.

blsmth commented 8 years ago

ahhhh, i see... so you have to prepend to allow the property but then strip it when you create the property resource. i hadn't run into that as i'm not running slaves on my masters. i'll take a look today and see what i can do.

i figured my fix was naive, i just wanted to explain the problem some more, code always helps me.

deric commented 8 years ago

I'm closing this as it doesn't seem to be the right solution for the problem.