Deleting keys from the options hash does not restart the service - Githubissues

deric / puppet-mesos

Puppet module for managing Mesos nodes

https://forge.puppetlabs.com/deric/mesos

Apache License 2.0

69 stars 61 forks source link

Deleting keys from the options hash does not restart the service #73

Closed rohte closed 8 years ago

rohte commented 8 years ago

When one deletes a key from the options hash there is no notify and therefore the service does not get restarted.

deric commented 8 years ago

Which version do you use?

rohte commented 8 years ago

latest

deric commented 8 years ago

Good, service notification was refactored in v0.7.0 mostly part of #56. AFIK we didn't handle deleted keys before.

I guess the issue is that we're applying purge on the configuration directory. If you delete a key, puppet will remove the corresponding file a nobody gets notified.

deric commented 8 years ago

@rohte I wrote a quickfix for the issue, could you test it?

rohte commented 8 years ago

Works fine for master and slave at least in our Vagrant set up. Tested by:

Start VM
Puppet apply
Check option is there
Remove some option
Puppet apply.
Check option is gone

deric commented 8 years ago

Great, I haven't tested whether this works for child directories like: /etc/mesos-slave/resources, but with recurse => true it should be ok. Reopen if you encounter any issues.

deric commented 8 years ago

Fixed in v0.8.1.