search

deric / puppet-sysctl_conf

Hiera based sysctl.conf management
0 stars 2 forks source link

Value types of `Float` and `Integer` #3

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

Can the sysctl_conf::entry define be extended to also support Float and Integer values? That would reduce the frustration when I forget to quote them...

deric commented 2 years ago

@jcpunk Is there any kernel parameter that would have a Float type? :slightly_smiling_face:

Some values really needs to be passed as strings:

vm.lowmem_reserve_ratio = 256   256     32      0       0

Having Integer and String should be sufficient, don't you think?

jcpunk commented 2 years ago

I'm not actually aware of any floats in the wild, but I suspect adding it now would prevent you needing to care in the future?

deric commented 2 years ago

Right, but currently the type checking might save us from some typos. When a Float is needed we'll tag a new release.

Released as v0.3.0.