search

dericcain / feather-theme

A light, elegant theme for Visual Studio code.
MIT License
7 stars 2 forks source link

Poor contrast with `inactiveSelectionBackground` when tracked file has modifications #4

Open drmonkeyninja opened 5 years ago

drmonkeyninja commented 5 years ago

Firstly, thanks for sharing this theme. It's a great colour scheme. However, the inactiveSelectionBackground doesn't work well when VS Code highlights changes to the selected tracked file. This is showing as either red or green text on the dark blue background which is hard to read.

Book_php_—_books

I've been personally getting around this by modifying the theme's colour scheme so that the inactiveSelectionBackground is a lighter blue which seems to work well (the inactiveSelectionForeground also needs darkening with this modification):

"workbench.colorCustomizations": {
    "list.inactiveSelectionBackground": "#c1e0f8",
    "list.inactiveSelectionForeground": "#395063"
},

Book_php_—_books

dgg commented 1 year ago

Same issue here. Feather is my go-to light theme and this is the issue that bugs me the most. Thanks for the workaround. Looking forward this issue being implemented in the theme.