search

derickr / dbgp

Common DeBugGer Protocol as used by Xdebug and other implementations.
http://xdebug.org/docs-dbgp.php
MIT License
23 stars 5 forks source link

Add a new "breakpoint_resolved" notification #11

Closed derickr closed 7 years ago

derickr commented 8 years ago

This new notification can be used to discover when breakpoints are resolved (see #8).

It is a better alternative to a combination of using the scope breakpoint from #9 in combination with breakpoint_list/breakpoint_get to find out whether breakpoints have been resolved. It does require IDEs to implement an additional top-level element (notification) in the debugging protocol however.

A debugger engine is not required to implement "breakpoint_resolved" notifications (or rather, any notifications at all).

johnislarry commented 8 years ago

LGTM, thanks!

jeffreytan81 commented 8 years ago

@derickr, sorry for the late comment. Do you want to call the new notification, "breakpoint_resolved" instead of "resolved_breakpoint"?

derickr commented 8 years ago

@yinghuitan Yes - that is an excellent point. I've fixed that.

jeffreytan81 commented 8 years ago

Thank you @derickr !

derickr commented 7 years ago

Merged after squash, rebase, and adding information to changelog.