Test Failures - Githubissues

derickr / vld

BSD 2-Clause "Simplified" License

464 stars 87 forks source link

Test Failures #45

Closed petermcd closed 4 years ago

petermcd commented 4 years ago

The following tests fail:

Test for jump calculation with catch() [tests/catch-php70.phpt]
Test for jump calculation with foreach() [tests/foreach-jumps-php70.phpt]
Test for issue #19 [tests/issue00019-php70.phpt]
Test for issue #20 [tests/issue00020-01-php70-64bit.phpt]
Test for issue #20 [tests/issue00020-02-php70-64bit.phpt]
Test for issue #21 [tests/issue00021-php70.phpt]

petermcd commented 4 years ago

The 32 bit might also fail (I am running 64bit so these were skipped)

petermcd commented 4 years ago

After looking at the tests it is clear that the output has changed significantly from when the tests were written to the current version of VLD.

I suspect the only potential way to resolve this is to pin the tests to a specific version of PHP otherwise new tests would have to be written regularly to account for changes.

derickr commented 4 years ago

Yeah, all the tests fail due to frequent changes in PHP itself. It's too much of a pain to maintain, so I am just going to close this issue. At some point, I'll fix them.