search

derickr / vld

BSD 2-Clause "Simplified" License
464 stars 87 forks source link

For switch-string, if there is special char like \n in the case, it will print in another line #59

Closed jimmyleeeeee closed 4 years ago

jimmyleeeeee commented 4 years ago

For the code below: case "\n": $out_string .= "\n"; break;

The \n is not encoded, vld will print the opcode after \n in another line. When print switch-string table, should encode the key and value.

jimmyleeeeee commented 4 years ago

I have fixed the issue and created a pull request (https://github.com/derickr/vld/pull/60/commits/4224383c8ee5aaaa06eaeb38967df55f6556482c). Please review it.

jimmyleeeeee commented 4 years ago

@derickr I know you are busy, can you take a little time to review whether the code is OK?

derickr commented 4 years ago

I had merged this on April 14th already, but I had forgotten to push my changes to GitHub. Should be there now, and thanks!