derickr / vld

BSD 2-Clause "Simplified" License
464 stars 87 forks source link

Possible accidental comparison #63

Closed jayay closed 4 years ago

jayay commented 4 years ago

Is this comparison intended? To me, it looks like != was supposed to be a |= assignment.

https://github.com/derickr/vld/blob/df26a348f279bb6edd3ee37b05ab12a592d95ed7/srm_oparray.c#L598

jimmyleeeeee commented 4 years ago

Yes, it looks strange. the code is useless as the comparison result is not used.