derisamedia / luci-theme-alpha

Luci theme for Official Openwrt and Alpha OS build ,based on bootstrap and material luCi theme,inspired on neobird LEDE theme
Apache License 2.0
151 stars 36 forks source link

菜单适配问题 #22

Open 281677160 opened 6 months ago

281677160 commented 6 months ago

QQ截图20240216211218 您好,菜单没有适配,不对齐了,应该要做一个判断,如果没发现您预定的菜单,就指定一个图标适配 比如这个主题(https://github.com/jerrykuku/luci-theme-argon)一样,没适配的菜单都是指定一个图标自动适配的

animegasan commented 6 months ago

您好,菜单没有适配,不对齐了,应该要做一个判断,如果没发现您预定的菜单,就指定一个图标适配 比如这个主题(https://github.com/jerrykuku/luci-theme-argon)一样,没适配的菜单都是指定一个图标自动适配的

The link you provided cannot be accessed, so this problem is because there is no icon for iStore, right?

animegasan commented 6 months ago

This is the location we can add iStore to themes

Add icon iStore

https://github.com/derisamedia/luci-theme-alpha/blob/634c44dc337507a1a7f1553778a1b4a0bc70a2a9/luasrc/gaya/gaya.css#L950-L960

.main>.main-left>.nav>li>[data-title="iStore"]:before {
  position: absolute;
  right: 14px;
  width: 25px;
  height: 25px;
  content: "";
  background: url(./icon/sidebar-icon/istore.svg) no-repeat;
  background-size: 25px;
} 

Add iStore css

.main>.main-left>.nav>li>[data-title="iStore"]

https://github.com/derisamedia/luci-theme-alpha/blob/634c44dc337507a1a7f1553778a1b4a0bc70a2a9/luasrc/gaya/gaya.css#L840 https://github.com/derisamedia/luci-theme-alpha/blob/634c44dc337507a1a7f1553778a1b4a0bc70a2a9/luasrc/gaya/gaya.css#L854 https://github.com/derisamedia/luci-theme-alpha/blob/634c44dc337507a1a7f1553778a1b4a0bc70a2a9/luasrc/gaya/gaya.css#L3120 https://github.com/derisamedia/luci-theme-alpha/blob/634c44dc337507a1a7f1553778a1b4a0bc70a2a9/luasrc/gaya/gaya.css#L3392

Results

image

Maybe later it will be added officially by @derisamedia

animegasan commented 6 months ago

image In my opinion, instead of making it have an icon for applications that are not registered as a theme, it would be better like the current one (not having an icon) so that more people participate in theme development.

Icons image istore

281677160 commented 6 months ago

图片 在我看来,与其让没有注册为主题的应用程序有图标,不如像现在的那样(没有图标),以便更多的人参与主题开发。

图标 图像 伊斯托雷

非常感谢您的付出,您说“与其让没有注册为主题的应用程序有图标,不如像现在的那样(没有图标),以便更多的人参与主题开发”,这句话对,也不对,很多人用了你的主题后,认为没有那个程序的图标,他就不用了,也不会跟您提出来啊,我前面跟您说的那个链接的主题,他就是判断程序没图标的,就指定一个图标,这样就不会搞的不对齐,那么难看了,然后就会有人发现,不一样才程序有相同的图标,到时候就会有人来问您某某程序的图标能不能换一个,慢慢的,你的主题就完善了