deriv-com / perl-WebService-Async-Onfido

Other
0 stars 15 forks source link

Test suite fails with older perls #47

Open eserte opened 11 months ago

eserte commented 11 months ago

The test suite fails on my smoker systems for older perls (< 5.24). The failures look either like

syntax error at t/onfido.t line 62, near "->%"
Type of arg 1 to Test::Exception::lives_ok must be block or sub {} (not reference constructor) at t/onfido.t line 64, near "'create applicant ok';"
...
# Looks like your test exited with 2 just after 1.
t/onfido.t ............... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 71/72 subtests 

or like

#   Failed test 'WebService/Async/Onfido.pm loaded ok'
#   at t/00-compile.t line 60.
#          got: '65280'
#     expected: '0'
Indirect call of method "catch" on a block at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 730.
Indirect call of method "try" on a block at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 725.
syntax error at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 689, near "%args{"
syntax error at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 689, near "} }"
Global symbol "%args" requires explicit package name at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 691.
...
Global symbol "$self" requires explicit package name at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 729.
syntax error at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 736, near "}"
/home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm has too many errors.
Compilation failed in require at -e line 1.
# Looks like you failed 1 test of 17.
t/00-compile.t ........... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/17 subtests 
    (less 2 skipped subtests: 14 okay)

If you don't plan to support older versions than you should probably add a minimum perl version specification.

eserte commented 11 months ago

Here a good fail/pass overview: http://matrix.cpantesters.org/?dist=WebService-Async-Onfido%200.007