DynamoDBTemplate should accept IDynamoDBMapper instead of DynamoDBMapper

derjust / spring-data-dynamodb

This module deals with enhanced support for a data access layer built on AWS DynamoDB.

https://derjust.github.io/spring-data-dynamodb/

Apache License 2.0

401 stars 141 forks source link

DynamoDBTemplate should accept IDynamoDBMapper instead of DynamoDBMapper #206

Open efenderbosch opened 5 years ago

efenderbosch commented 5 years ago

I'm creating an instance of DynamoDBTemplate in some tests and just noticed that the constructor uses the DynamoDBMapper class instead of an IDynamoDBMapper interface. Not a huge deal as I can cast my IDynamoDBMapper to DynamoDBMapper but that really shouldn't be necessary.

derjust commented 5 years ago

Good catch (And totally agree) & Easy to fix. Thanks!

derjust commented 5 years ago

Sadly less easy than expected at first.. AWS SDK uses the concrete class for com.amazonaws.services.dynamodbv2.datamodeling.PaginatedQueryList

Working on it

efenderbosch commented 5 years ago

Ugh. Should I open a bug w/ them for that?

efenderbosch commented 5 years ago

Opened an issue for that.

https://github.com/aws/aws-sdk-java/issues/1802

derjust commented 5 years ago

Appreciate opening the bug!