search

derkalle4 / python3-idotmatrix-client

reverse engineered python3 client to control all your 16x16 or 32x32 pixel displays (experimental)
GNU General Public License v3.0
200 stars 41 forks source link

Refactoring Common() methods #15

Closed tekka007 closed 10 months ago

tekka007 commented 10 months ago

Refactoring and type casting methods in Common class, incl. their usage

derkalle4 commented 10 months ago

Forgot one point I've overseen. From my perspective the --flip-screen should be "true" and "false" instead of "on" and "off" to suggest that you can enable or disable the screen instead of turning that feature on or off.

I would however make "toggle-screen" to use "on" or "off" or rename it to "enable-screen" which then would match "true" and "false" respectively.