derkalle4 / python3-idotmatrix-client

reverse engineered python3 client to control all your 16x16 or 32x32 pixel displays (experimental)
GNU General Public License v3.0
200 stars 41 forks source link

Added a possibility to show and set address of the Display #16

Open rodrigosiviero opened 10 months ago

rodrigosiviero commented 10 months ago

I added some functions because I feel that lacks for new users to being able to find the display addresses, if it's not good enough maybe it help someone, great project guys, really great cannot wait for rest API so I can Integrate with Home Assistant!

./run_in_venv.sh --device-address show
./run_in_venv.sh --device-address set
derkalle4 commented 10 months ago

Hi @rodrigosiviero

many thanks for your pull request. I see you have changed many other things as well (I bet automatically due to some formatting tool within your IDE). Maybe we should agree on one standard to make it look the same for everyone.

However, thanks for your work! This would help with #17

Anyway, I will need to look further into it because I don't know which ways we should support to set the address (yet). I am planning on supporting multiple devices as well and use yaml for this. Unfortunately I haven't got the time to implement this as well. But then it would include some kind of configuration file which the app.py could read upon startup.

Will report back later when I got more time to look into your changes.