search

derkalle4 / python3-idotmatrix-library

This library talks to displays originally used with the iDotMatrix Android & iOS App.
GNU General Public License v3.0
30 stars 6 forks source link

GIF: upload chunks individually #1

Closed leromarinvit closed 3 months ago

leromarinvit commented 5 months ago

Uploading GIFs > 4096 bytes doesn't work - it seems the chunks must be sent in separate transfers.

With this change, all 1- and 2-chunk GIFs I've tried work now. But images with 3 or more chunks still cause problems, so something must be wrong still.

derkalle4 commented 3 months ago

Hi @leromarinvit many thanks for your push-request. Sorry for the delay... I'll merge your commit as this seems working for me. Many thanks! :)

derkalle4 commented 3 months ago

Btw the pull-request is marked as "work in progress". Please set it to "Ready for review" once I can push it.

leromarinvit commented 3 months ago

You're right, this is an improvement even in the current state, even if it's not perfect.

derkalle4 commented 3 months ago

Many thanks @leromarinvit - I have integrated it. Whenever you have made additional progress feel free to hand in another pull-request :)