Hi Roger, thanks a lot for submitting this! There are a few things which would need to be addressed before a merge.
I think it should not be forbidden to add any node of choice below any state chart node. I'm not aware of any other node in Godot that would complain about this, so I think this add-on should handle this as gracefully as the rest of Godot does.
When add_node is overridden, all given parameters should be forwarded to the call to super, not just the node.
The initial state should only be automatically set when in the editor, not at runtime.
To check if a node is a state one can simply do an node is State. There is no need to add a marker property for this.
The PR adds changes to a range of import files which are unrelated to the actual change, so they should not be in there.
After reading this PR I noticed that I didn't set up a contribution guide yet, which could have avoided the extra work. I'm sorry that I didn't think of this earlier.
To save you some time, I have extracted the relevant changes and manually edited them into the code base. I have created a new release and credited you in the change log.
I hope this is OK with you. Thanks again for submitting this PR!
Hi Roger, thanks a lot for submitting this! There are a few things which would need to be addressed before a merge.
add_nodeis overridden, all given parameters should be forwarded to the call tosuper, not just the node.node is State. There is no need to add a marker property for this.After reading this PR I noticed that I didn't set up a contribution guide yet, which could have avoided the extra work. I'm sorry that I didn't think of this earlier.
To save you some time, I have extracted the relevant changes and manually edited them into the code base. I have created a new release and credited you in the change log.
I hope this is OK with you. Thanks again for submitting this PR!