search

derkork / godot-statecharts

A state charts extension for Godot 4
MIT License
679 stars 33 forks source link

The `StateChartDebugger` icon should be at least partially green #94

Closed mieldepoche closed 3 months ago

mieldepoche commented 4 months ago

Icon colors in godot are tied to the "nature" of the node. Which is what I get from this addon's nodes: orange things with an outline are StateChart components, inheriting from Node, with no transform. You learn while using the addon that orange things have no visuals. The StateChartDebugger however is a a control node (well it's a scene of control nodes) but it still has the orange component color.

I believe that for consistency, this icon should get colored with godot's green rather that the current orange, to make it clear that it's an ui component at a glance.

current proposal A proposal B
image image image

I think A is better because it references both of its behaviors: it's a ui widget that tracks the orange things.

svg icons A and B: icons.zip

derkork commented 3 months ago

Well I really can't tell the difference between current and A (A seems to be very slightly different) but B seems to have the same color as the other UI widgets, so we can run with that. Thanks for supplying the icons!

mieldepoche commented 3 months ago

Well I really can't tell the difference between current and A

A only has the outline turned green: image

derkork commented 3 months ago

I'll go with the fully green one, as it stands out a bit more for people with deficient color vision like me 😸 Thanks again for supplying the icon!