search

dermatz / ddev-woodoo-buildtools-magento

ddev Addon to build Magento projects without headache
GNU General Public License v3.0
7 stars 2 forks source link

Warn if a "frontend" command exist during installation #25

Closed dermatz closed 3 weeks ago

dermatz commented 2 months ago

Could not run/install command ddev frontend init if "frontend" command already exists.

Morgy93 commented 2 months ago

It throws the error:

NOT overwriting .ddev/commands/web/frontend.
The #ddev-generated signature was not found in the file, so it will not be overwritten.
You can remove the file and use DDEV get again if you want it to be replaced: signature was not found in file .ddev/commands/web/frontend

So it's by design and I think we should not interfere with it. 😕

rfay commented 2 months ago

Apparently the frontend has been modified by the user, since the original has #ddev-generated in it:

https://github.com/dermatz/ddev-woodoo-buildtools-magento/blob/main/commands/web/frontend#L2

So if you don't care about the modifications, just remove that file and a ddev get will work without errors.

dermatz commented 1 month ago

In the agency environment, it has happened now and again that some developers have built their own frontend command, which now clashes with ours. So my plan is to check in advance and tell the user that such a file exists and to overwrite it directly if necessary, even if there is no #ddev-generated.

dermatz commented 3 weeks ago

It throws the error:

NOT overwriting .ddev/commands/web/frontend.
The #ddev-generated signature was not found in the file, so it will not be overwritten.
You can remove the file and use DDEV get again if you want it to be replaced: signature was not found in file .ddev/commands/web/frontend

So it's by design and I think we should not interfere with it. 😕

Yes, I'm fine with that. All needed information about the case are given during the installation. The user just needs to use his eyes.

I will close this ticket and PR right now.