Closed writeson closed 2 months ago
Hey Doug,
This is around the font-awesome git submodule in the scss folder. Updating font-awesome to V6 was tricky as they removed their public CDN.
I've been mulling over a PR on how to fix this, using it as a git submodule was always a temporary solution. I'm not experienced with Netlify so I can't help with the exact deployment issue with why it'd have an issue with the submodule. For your immediate issue you could consider just forking the theme and coping the font-awesome-sass files in, should do the trick.
The long term solution here is to include the icon SVGs directly in the theme like other popular Hugo themes. As this would just make it easier to deploy in general.
Chris,
Thanks for getting back to me. Very much appreciated. I probably won't get to fool around with this before the end of the weekend as we're going to be baby-sitting our grandson this weekend. But I didn't want to go to long before responding. When you say "copying the font-awesome-sass file in", what do you mean by that?
Again, thanks. I'll let you know how I make out later on.
Doug Farrell
On Tue, Jun 4, 2024 at 6:22 PM Chris @.***> wrote:
Hey Doug,
This is around the font-awesome git submodule in the scss folder. Updating font-awesome to V6 was tricky as they removed their public CDN.
I've been mulling over a PR on how to fix this, using it as a git submodule was always a temporary solution. I'm not experienced with Netlify so I can't help with the exact deployment issue with why it'd have an issue with the submodule. For your immediate issue you could consider just forking the theme and coping the font-awesome-sass files in, should do the trick.
The long term solution here is to include the icon SVGs directly in the theme like other popular Hugo themes. As this would just make it easier to deploy in general.
— Reply to this email directly, view it on GitHub https://github.com/derme302/triple-hyde/issues/15#issuecomment-2148507689, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACGYHIYYHKSWFIXJ43S56LZFY4Z7AVCNFSM6AAAAABIVMQDR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGUYDONRYHE . You are receiving this because you authored the thread.Message ID: @.***>
The font-awesome-sass files exist as a git submodule in the project. Git submodules are a bit of a pain and don't always clone correctly with older versions of git. I think the short term fix would be just to remove the submodule and include them directly with the project.
However, I think this is a pretty important feature for the project so I've already mocked together what switching to SVGs would look like over on the dev/font-awesome-svg
branch. It is working but still needs some documentation and I'm hoping to merge it once that is done. Let me know if you have any issues deploying that branch on Netlify otherwise I'll consider this resolved once that branch is merged.
Hi Chris,
Thanks for the updates to Triple-Hyde, that fixed my Netlify deployment issue. I've got my site deployed and running:
https://happycanvasandcode.com/
Again, thanks for your help with this!
Doug
On Tue, Jun 4, 2024 at 6:22 PM Chris @.***> wrote:
Hey Doug,
This is around the font-awesome git submodule in the scss folder. Updating font-awesome to V6 was tricky as they removed their public CDN.
I've been mulling over a PR on how to fix this, using it as a git submodule was always a temporary solution. I'm not experienced with Netlify so I can't help with the exact deployment issue with why it'd have an issue with the submodule. For your immediate issue you could consider just forking the theme and coping the font-awesome-sass files in, should do the trick.
The long term solution here is to include the icon SVGs directly in the theme like other popular Hugo themes. As this would just make it easier to deploy in general.
— Reply to this email directly, view it on GitHub https://github.com/derme302/triple-hyde/issues/15#issuecomment-2148507689, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACGYHIYYHKSWFIXJ43S56LZFY4Z7AVCNFSM6AAAAABIVMQDR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGUYDONRYHE . You are receiving this because you authored the thread.Message ID: @.***>
Wonderful, glad we could get that issue sorted. Site looks great.
Hi,
I'm new to Hugo and I'm trying to use it to build a blog hosted on Github and deployed with Netlify. When I try to deploy using Netlify the deploy log shows this error:
I've tried many things to resolve this (making triple-hyde a git submodule, editing the triple-hyde.scss file directly, adding a build step to the package.json file to copy the files from node_modules into the themes assets folder, and more), but no change.
At the moment I'm stumped and could use some help/guidance.
Thanks in advance! Doug