search

dermen / sim_erice

1 stars 1 forks source link

several updates #5

Closed dermen closed 2 years ago

dermen commented 2 years ago
dermen commented 2 years ago

This is the changes needed to annotate hkl information as mouse moves.. also and importantly, this PR also changes the reset method to not reinstntiate diffBragg, rather just reset the Umatrix .. .

mewall commented 2 years ago

Excellent!

I was thinking I’d try to work on getting the diffuse anisotropic to track the crystal orientation, but I’m not sure whether I’ll be able to get a development build working on my laptop. Let me know if you make any progress on that…

Sent with BlackBerry Work (www.blackberry.com)

From: Derek Mendez @.**@.>> Date: Thursday, Jun 02, 2022, 10:49 AM To: dermen/sim_erice @.**@.>> Cc: Subscribed @.**@.>> Subject: [EXTERNAL] [dermen/sim_erice] several updates (PR #5)

You can view, comment on, or merge this pull request online at:

https://github.com/dermen/sim_erice/pull/5https://urldefense.com/v3/__https://github.com/dermen/sim_erice/pull/5__;!!Bt8fGhp8LhKGRg!QL-ycZibRSO4EaZil_IldbcGSKA7E844XPRBfL0wTmGTvdTZF0Un1xFJtK71H0w$

Commit Summary

File Changes

(2 fileshttps://urldefense.com/v3/__https://github.com/dermen/sim_erice/pull/5/files__;!!Bt8fGhp8LhKGRg!QL-ycZibRSO4EaZil_IldbcGSKA7E844XPRBfL0wTmGTvdTZF0Un1xFJqIMg76g$)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/dermen/sim_erice/pull/5__;!!Bt8fGhp8LhKGRg!QL-ycZibRSO4EaZil_IldbcGSKA7E844XPRBfL0wTmGTvdTZF0Un1xFJtK71H0w$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA67VEN3H4K6KB7TYEJSTC3VNDQZZANCNFSM5XVSMWKQ__;!!Bt8fGhp8LhKGRg!QL-ycZibRSO4EaZil_IldbcGSKA7E844XPRBfL0wTmGTvdTZF0Un1xFJqqDM4yc$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

dermen commented 2 years ago

@irisdyoung did you want to pull this in ? I wanted someone else to test it fist

irisdyoung commented 2 years ago

I don't understand the (x,y) values displayed -- they aren't correlated with resolution and they aren't the pixel positions on the detector -- they seem to be canvas (x,y), in which case I don't think we want to display this.

fractional and integer hkl and the rest work great for me.

I'm getting some weird viewer behavior when I move outside the canvas limits. The canvas flickers and resizes a little. Maybe we need to do some check for whether we're outside bounds?

irisdyoung commented 2 years ago

I am also wondering if we want to display |F| = 0 when the nearest hkl does not produce any pixels on the display.

irisdyoung commented 2 years ago

I am comparing with the current version and noticing that the irrelevant (x,y) is mine ... interested to hear your opinion on it @dermen and in the mean time merging your pull request in.

irisdyoung commented 2 years ago

Walking back my earlier claim -- x,y are indeed pixel positions and these stay accurate when zoomed. Would probably be worth labeling things at this point, including RGB values which are easy to confuse with hkl since they're a tuple of the same length.