dermesser / leveldb-rs

A reimplementation of LevelDB in Rust (no bindings).
Other
521 stars 59 forks source link

feature: Hide `PosixDiskEnv` type behind a feature (default enabled) #38

Closed NumberFour8 closed 1 year ago

NumberFour8 commented 1 year ago

Building rusty-leveldb in constrained or non-POSIX environments (such as WASM) is currently not possible. This PR adds small changes to make it possible.

Changes

dermesser commented 1 year ago

Thank you very much! I've left a few comments, but overall it looks good.

NumberFour8 commented 1 year ago

Thank you very much! I've left a few comments, but overall it looks good.

Thanks for the feedback :) I adapted the code according to your comments.

NumberFour8 commented 1 year ago

@dermesser Is this good to merge, then?

dermesser commented 1 year ago

Yes apologies for the delay. I will shortly release a new major version