dermotbradley / create-alpine-disk-image

Create cloud-init enabled Alpine disk images for physical machines (PCs & RPIs), VMs, and Cloud servers
GNU General Public License v2.0
93 stars 11 forks source link

Script fails to check is `limine` is installed #43

Closed Forza-tng closed 1 year ago

Forza-tng commented 1 year ago

The script fails to check that limine and limine-deploy is installed when using --bootloader limine.

I am running on Alpine 3.18.

==> initramfs: creating /boot/initramfs-virt
[2023-07-15 09:44:34] chroot: Configuring Limine
[2023-07-15 09:44:34] chroot:   Creating limine.cfg
[2023-07-15 09:44:34] chroot:   Installing Limine bootloader
[2023-07-15 09:44:34] chroot:     Running limine-deploy
/bin/sh: limine-deploy: not found
[2023-07-15 09:44:34]   Unmounting /tmp inside chroot
[2023-07-15 09:44:34]   Unmounting /dev inside chroot
[2023-07-15 09:44:34]   Unmounting /sys inside chroot
[2023-07-15 09:44:34]   Unmounting /proc inside chroot
[2023-07-15 09:44:34]   Unmounting root filesystem inside chroot
[2023-07-15 09:44:34]   Freeing up loop device '/dev/loop0'
dermotbradley commented 1 year ago

The limine packaging in Alpine Edge changes a few weeks ago and there is no longer a limine-deploy package and some other stuff changed.

I've made a code change in #44 that should handle this - I haven't yet tested it however.