dermotduffy / frigate-hass-card

A Lovelace card for Frigate in Home Assistant
MIT License
553 stars 59 forks source link

JSMPEG view generates a lot of "login attempt failed" errors in HA #109

Closed alexdelprete closed 2 years ago

alexdelprete commented 3 years ago

It only happens with frigate-jsmpeg. If I switch to webrtc I don't see these.

2021-10-09 02:43:59 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:05 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:11 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:17 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:24 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:31 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:39 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
2021-10-09 02:44:46 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4644.0 Safari/537.36 Edg/96.0.1032.0)
dermotduffy commented 3 years ago

This is already fixed, but not yet released. See the workaround here: https://github.com/dermotduffy/frigate-hass-card/issues/103#issuecomment-938306505

alexdelprete commented 3 years ago

This is already fixed, but not yet released. See the workaround here

I'm the one who found the workaround in #92, precisely in this comment :)

But it doesn't solve the bad login warnings in the log, otherwise I would not have them since I'm using the workaround since then.

dermotduffy commented 3 years ago

My apologies, too many issues / things in flight!

No chance you have multiple cards and one of them doesn't have the camera name specified? Are you actually seeing JSMPEG failing somewhere, or just the log entries accumulating?

alexdelprete commented 3 years ago

No problem, that's why I added the smile. I know it gets confusing. :)

Nope, I have 1 card and 1 camera (a doorbell). JSMPEG works fine, but many authentication errors, like other users reported in the other issue, can't remember the #, where you suggested to put the optional camera name to fix JSMPEG. They see those login errors too.

I think that JSMPEG opens several unauthenticated sessions to HA in the init phase...hence those errors...but I'm just speculating...

dermotduffy commented 3 years ago

OK, so it appears to work fine, but you end up with log lines. Hmm.

I don't think that theory is correct, as there's only one URL passed to JSMPEG and it's an authenticated/signed one. JSMPEG doesn't know anything about HA, it's the card that is linking JSMPEG+HA (and doing so only with one single URL).

If it's not just a rogue card you have running somewhere else (without frigate_camera_name) the only other thing I can think of is somehow the camera name is getting messed up and so the Frigate integration is rejecting the URL for some reason.

Since you're comfortable with the JS debugger (as I recall from the other bug), I wonder if you could attach a breakpoint here:

https://github.com/dermotduffy/frigate-hass-card/blob/main/src/components/live.ts#L223

... and then see what the value of jsmpeg_url is? (By just typing jsmpeg_url into the console after the breakpoint is reached).

alexdelprete commented 3 years ago

Sorry Dermot but I'm not really a JS expert, I'm a good tinkerer, and I'm using MS Edge internal debugger.

Couldn't find the live.ts code anywhere, but I played a little bit with the debugger, and this is what I came up with:

I started the debugger/console while in edit mode of the frigate-hass-card, so I had the options open and the preview, it was working, but when I went to console I found these errors:

image

I noticed the url contained a double frigate/frigate path, I don't know if that's correct. So I went in the source code of frigate-hass-card.js (it's the only source I see in the debugger) and put a breakpoint here:

image

I also put this.url in Watch section of the debugger. When it stopped on the breakpoint, the content of the url was:

ws://hass.axel.dom:8123/api/frigate/frigate/jsmpeg/citofono?authSig=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiIyNjJhZTU1MmNkMzU0MjJjOTE1ZDdiZjNlMDBkZjk3ZSIsInBhdGgiOiIvYXBpL2ZyaWdhdGUvZnJpZ2F0ZS9qc21wZWcvY2l0b2Zvbm8iLCJpYXQiOjE2MzM4MTg2NzksImV4cCI6MTYzMzgxODcwOX0.E6uYTU2PmyZ8r2f48XlZbJEMVJFM_DQiOxLb2lnRDls"

The only thing strange I notice is the double path frigate/frigate, but maybe it's correct, I don't know.

I hope that's the url you were looking for, and sorry if I'm not that good with JS stuff.

dermotduffy commented 3 years ago

Thank you! I wouldn't normally request debug digging, but from the other bug I figured you were comfortable with it -- really appreciate your efforts. Everything you showed looks normal:

So your debugging shows that the workaround you applied is working correctly, and that the request is failing for some other reason. So I'm afraid I still have no clue why your requests are failing. I'm going to do a pre-release today, so I'd suggest you try that out (but this is a long-shot).

Last question: What HA version are you using? (Just in case it's something really old or really new...)

I'll leave this bug open for now in case someone else runs into this and/or I figure out what might be causing you this issue or manage to reproduce it myself.

alexdelprete commented 3 years ago

It's a pleasure helping you devs, I learn something new while doing it every time. Now I know a little bit how JS stuff is being debugged. :)

Thanks for the explanations, I really appreciate you taking the time to do it instead of simply saying you can't reproduce it.

I'm on 2021.10.x of HA. I just upgraded to 10.3 and 1.2 of your card. Will let you know if behaviour is still the same. If I don't see the login issue anymore right now, but it's too early to say. Will keep you posted.

Thanks for everything you are doing and the great support here.

lcasale commented 3 years ago

I'm still getting occasional authentication errors (although not nearly as many as @alexdelprete) with HA 2021.10.3 and card 1.2

dermotduffy commented 3 years ago

@alexdelprete Just checking in Alessandro, are you still seeing these errors in your log recently?

I continue to have no examples on my end:

$ grep "Login attempt or request" /etc/home-assistant/home-assistant.log
$
alexdelprete commented 3 years ago

Just checking in Alessandro, are you still seeing these errors in your log recently?

Thanks for asking. Yes, I still see some errors:

2021-10-18 00:42:50 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64;x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 00:42:50 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64;x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)

When I have a login error notification in HA, in order to not have it repeat every 3 secs, I simply do a ctrl-F5 to refresh the page. Then I can use HA without warnings. But usually it happens when I hopen the lovelace card with the JSMPEG live view. I'm not 100% sure if the problem is that though. When I used webrtc instead of JSMPEG, I didn't have warnings.

dermotduffy commented 3 years ago

Do you get these messages immediately upon loading, or it takes some time for them to appear? If the latter, any idea how long?

[I'm wonder if it's some auth expiration issue and/or if I'm not waiting long enough with the JSMPEG live view loaded]

alexdelprete commented 3 years ago

Immediately on loading...before the stream is shown...

I just restarted HA to update some components, and when I went to the card...it didn't happen...no warnings.

Also, the fact that after refresh of the page it doesn't happen anymore, has to mean something...unfortunately I'm not able to consistently reproduce it. It's not the browser, because it also happened when I used the HA mobile client.

dermotduffy commented 3 years ago

Experimental fix will be in the next build to extend the expiration of the signed JSMPEG URL. I think this is a long-shot, but as I still cannot reproduce this myself "naturally" it's worth a shot to see if it helps. This would fix the issue if too long of a time elapsed between signing the URL, and JSMPEG player using it -- the merged PR expands that expiry time. If I reduce the expiry time, I can reproduce the error messages included in this bug myself, so perhaps some delay is causing you to hit that expiry time sooner?

Lets see where we stand after the next build ...

alexdelprete commented 3 years ago

I just upgraded to last version of the card and restarted HA, I waited a couple of minutes that things settled and then I opened up the browser, and now it's always doing it, every few secs I receive a notification warning.

I wish I could debug this properly, this would be the perfect moment.

2021-10-18 12:06:06 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:11 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:16 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:21 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:26 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:31 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:36 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:41 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:46 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:51 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:06:56 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:01 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:06 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:11 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:16 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:21 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:27 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:33 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:39 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:45 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:51 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:07:57 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:03 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:09 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:15 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:21 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:27 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:33 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
2021-10-18 12:08:39 WARNING (MainThread) [homeassistant.components.http.ban] Login attempt or request with invalid authentication from G37.axel.dom (10.1.10.41). (Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.1043.1 Safari/537.36 Edg/96.0.1043.1)
dermotduffy commented 3 years ago

Thanks for trying it -- it was a long-shot anyway. OK, lets continue to leave this bug open and see if others have the same issue and/or if anyone figures out a pattern of when/how it happens.

alexdelprete commented 3 years ago

If I find something I'll let you know...thanks for your support.

oramirite commented 3 years ago

Just wanted to chime in that I'm getting this issue as well. It kicked off at a strange time too - I had upgraded this card much earlier in the day, but it wasn't until I started reloading my automations.yml file that I started to get this. I've basically been flooded with these messages ever since.

Mincka commented 3 years ago

I have a tablet with a few cards in live view with JSMPEG. If I restart the addon, the cards becomes black and at this time I start getting authentication errors. As soon as I refresh the browser, the cards reload, with the live view in JSMPEG and the authentication errors stop. So in my opinion, it happens when the connection breaks (for any reason). The card is unable to identify it and reset its session automatically.

dermotduffy commented 3 years ago

I think we may have a few related failure modes mixed in here, which is what is making this harder to track down:

  1. Signed URL for JSMPEG expires but remains functional while connected, but once the connection is broken it cannot re-establish the connection with the same expired URL. This could probably happen when either Home Assistant Core itself restarts, or when the Frigate backend restarts.
  2. OR: The URL just plain expires.

I think a solution here would be:

alexdelprete commented 3 years ago

When the problem is triggered, it happens every 3-4 seconds, it can't be an expiration issue.

In order to solve it (works 80% of the times) I do a ctrl-f5 in the browser a couple of times.

dermotduffy commented 3 years ago

The player is likely just retrying the old expired/broken URL every 3 seconds. The pace of retries is not related to the expiry length.

alexdelprete commented 3 years ago

But when I connect the first time, the URL is not refreshed? So why does it continue to be expired?

Another question: what could we do to debug in detail the HA error message? Can I use logger to debug a specific component so we have more detailed info about the error?

dermotduffy commented 3 years ago

[Quick reply] I still can't explain why you get this error on initial load. A full reload of the card will always get a fresh signed URL, and should ~always work. If the signing itself fails, an error message is rendered on the card, and the player isn't even created (so the logged messages would never happen in this scenario).

Note that by "full reload" I mean a full browser refresh, not just HA restarting or changing dashboards in the UI.

I plan to prioritize work on debugging this this coming weekend.

Mincka commented 3 years ago

Here's my debug log if it helps. I get this just by having a single frigate card in a dashboard with the dev console open. In another windows, I restart the addon.

image

At this end of this example, the card managed to connect again after a few minutes. It happened twice during my testing. It looks like it was related to this message in the console at the same time. image

I am not sure what triggered this and don't know if it will help.

About the multiple reloads required: In my case, the authentication error always stops after the first reload. You must be sure that you don't forget another tab with the card somewhere (on the same device, on another one, on a phone...) that may be still causing the issue.

blakeblackshear commented 3 years ago

I am initializing JSMpeg in the web UI with audio disabled. I don't think it has anything to do with this issue, but it should prevent that console message.

alexdelprete commented 3 years ago

I am initializing JSMpeg in the web UI with audio disabled. I don't think it has anything to do with this issue, but it should prevent that console message.

Thanks for this Blake. I'll test it and report back.

Dermot: since you merged the disable audio for JSMPEG fix, I reinstalled the card (used branch main). Will let you know if errors are gone.

dermotduffy commented 3 years ago

@alexdelprete I would be absolutely stunned if that audio merge fixed the issue, it's 99% totally unrelated I'm afraid.

In a spot of good news, I did find out why I wasn't getting any error messages at all. My development instance for Home Assistant had IP banning disabled. Once it was re-enabled, I can get these messages to occasionally pop-up -- so at least I have something to test against now.

[This does mean a workaround to get rid of these messages would be:

http:
  ip_ban_enabled: false

... in your configuration.yaml, although that clearly has undesirable security properties, so definitely not the real fix]

alexdelprete commented 3 years ago

I would be absolutely stunned if that audio merge fixed the issue

Well, since I installed the main branch, NOT EVEN 1 EPISODE. So you can start being stunned. :)

One thing I don't understand that Blake wrote: "it has nothing to do with the issue, but it prevents the message". What does it mean? If it prevents that message it means it solved the issue. Didn't get that one very clear...my bad. :)

[This does mean a workaround to get rid of these messages would be:

Well, I knew that since the beginning, but I decided not to do that because it's not a solution, it's a workaround that creates a security hole.

Another thing: with this main branch, when I open the dashboard with the frigate card, it shows almost immediately, before that, I saw it empty, than a white rectangle, then the stream popped up, so a total of 2-3 secs to see the video. Now it's instantaneous. So probably the audio stream was the issue. I don't know...just telling you what I observe.

dermotduffy commented 3 years ago

Blake was referring to the audio fix removing this harmless console message not the log messages that this bug is about.

It's possible there are multiple issues here, I never understood why you were getting these messages on card load. PS: I did also add 'live_preload' support to the card, if you have live_preload in your configuration that may be why it's suddenly instantaneous ;)

alexdelprete commented 3 years ago

Blake was referring to the audio fix removing this harmless console message not the log messages that this bug is about.

Ohhh..now I see. Sorry for that.

I never understood why you were getting these messages on card load

I don't know if it's on card load, I have it when I open the dash that contains the card, so I guess that's when it gets loaded/refreshed, but I'm not sure.

Bear in mind it also happens if I'm NOT in lovelace, but I just opened HA for the first time.

Might also be an HA bug: but it started since I use frigate-card, I should uninstall it and check if I still have errors.

Anyway, now that you receive the same errors, I'm sure you'll nail the problem. :)

PS: I did also add 'live_preload' support to the card, if you have live_preload in your configuration that may be why it's suddenly instantaneous ;)

It's off. But the behaviour is like it was on. Now I turned it on. ;)

image

dermotduffy commented 3 years ago

OK, PR merged which should help with this. For anyone who is testing it out, if you continue to see the errors doublecheck that the IP address logged is actually from where you're testing this and not another device (tripped me up!).

alexdelprete commented 3 years ago

Thanks Dermot. I just reinstalled selecting the main branch from HACS. I'm not always sure it does that, would be better tagging as beta release in these cases because I have no way of checking effectively what version I'm running if it's not tagged as release or beta. :)

I hope this solves the issue, will keep you posted...

dermotduffy commented 3 years ago

There's no build with these changes yet, so you'd need to build your own. I'll be doing another beta build in a few days hopefully if you'd rather just wait before trying it out.

alexdelprete commented 3 years ago

I already installed from HACS selecting "main" as version. It's working. No login errors in last 2 hours...

Mincka commented 3 years ago

Hi, I just tested 1.2.1 as beta in HACS and this issue is completely gone for me. 3 cards are loaded on 2 PCs and 1 mobile at the same time. I restart the addon to simulate the connection drop/expiration. No login error and the streams are reinitialized very fast. Great job!

alexdelprete commented 3 years ago

Hi, I just tested 1.2.1 as beta in HACS and this issue is completely gone for me.

I can't confirm, I still have the same issue with last beta (1.2.1). When it starts doing it, the only solution is a ctrl-F5 and it stops.

Furthermore, I upgraded to HA 11.0b1 and the icons on the card have disappeared, but I'll open another issue for this problem. I think it's an HA issue.

image

Mincka commented 3 years ago

Finally, after a few hours, it continues but I don't manage to fix it with ctrl+F5 in my case. Login attempt or request with invalid authentication from localhost (127.0.0.1). See the log for details. Do you also have errors from localhost sometimes @alexdelprete ? I need to investigate further on my side. It could related to something else.

dermotduffy commented 3 years ago

I would recommend you don't bother testing this right now, and wait for the next build as I am hopeful it will resolve it. I'll ping this thread when the build is ready, probably within the next week.

alexdelprete commented 3 years ago

Do you also have errors from localhost sometimes @alexdelprete ?

Never from localhost, always from the IP of my notebook or the IP of my mobile phone, from where I access HA.

Maybe you use a proxy to access HA?

alexdelprete commented 3 years ago

I would recommend you don't bother testing this right now, and wait for the next build as I am hopeful it will resolve it. I'll ping this thread when the build is ready, probably within the next week.

So you were able to reproduce it? Great news.

dermotduffy commented 2 years ago

There's a v2.0.0 pre-release that maybe will fix this issue:https://github.com/blakeblackshear/frigate/discussions/1590#discussioncomment-1602062

Anyone who is still seeing these log entries with a JSMPEG live view, check it out ;-)

alexdelprete commented 2 years ago

I was waiting for it...:)

Installed it a couple of hours ago...will let you know...thanks a lot.

alexdelprete commented 2 years ago

Dermot, I can confirm the problem is fixed, I only had 1 event since I installed it, and it was a couple of hours after the upgrade to this latest pre-release version. :)

Everything's working smoothly, great job, thank you so much for the support, I appreciate it.

Alessandro

felipecrs commented 2 years ago

I started to get these all the time again, but I believe it's since the card was updated to v3.0.0-rc.1.

felipecrs commented 2 years ago

@dermotduffy if I'm the only one with this issue, please do not delay the v3.0.0 release because of it.

dermotduffy commented 2 years ago

@felipecrs Is this still happening for you with v3.0.0-rc.1? If yes, if you had a description of how to reproduce, I'd appreciate!

felipecrs commented 2 years ago

Yes, still happening with v3.0.0-rc.1. But I have no clue on what makes my environment special to trigger this issue. I just know that if I restart HA, I start to receive a lot of these errors for the next several minutes. After some minutes (maybe hours?) online, I stop receiving them.

So, I have an environment where I can reproduce, but I don't know how you can reproduce it... in case it helps, and you are willing to, we can have a call on Discord (felipecrs#8767) or anywhere else.

dermotduffy commented 2 years ago

Sent you a discord invite!

But let me play around with it a little. Knowing it happens to you on restart gives me something to start with.

oramirite commented 2 years ago

I'm sorry for the unhelpful comment... but this whole thing is ridiculous. This whole issue is dancing around Home Assistant's absolute trash logging. If it gave us a little bit more information this issue would have been solved last year.

Sorry but I consider it absolutely insane that a little tiny bug in a plugin causes a false positive security error. If I seem fustrated it's because I am.... HA doesn't give 2 craps about security, and the fact that this error can be triggered by the technical equivalent of a speck of dust floating by is evidence of that.

Just to be clear: at this point it's become clear to me that this error is no fault of the plugin author. This same error gets caused by other plugins and the log messages are similarly useless.

I don't know how we're going to solve this problem without escalating the root cause of not having enough logging information to identify the issue. Nabu Casa needs to take a look at this point and give us better tools to find the issue.

EDIT: Glad to hear you seem to have fixed it anyway. Great work!!

On Thu, Mar 3, 2022, 10:26 PM Felipe Santos @.***> wrote:

Yes, still happening with v3.0.0-rc.1. But I have no clue on what makes my environment special to trigger this issue. I just know that if I restart HA, I start to receive a lot of these errors for the next several minutes. After some minutes (maybe hours?) online, I stop receiving them.

So, I have an environment where I can reproduce, but I don't know how you can reproduce it... in case it helps, and you are willing to, we can have a call (Discord (felipecrs#8767) or anywhere else).

— Reply to this email directly, view it on GitHub https://github.com/dermotduffy/frigate-hass-card/issues/109#issuecomment-1058789875, or unsubscribe https://github.com/notifications/unsubscribe-auth/APUWDRU3EPLIW4DBV63H4S3U6F7FXANCNFSM5FUWFBAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>