dermotduffy / frigate-hass-card

A Lovelace card for Frigate in Home Assistant
MIT License
470 stars 52 forks source link

"Menu>Button: Download" shows download button even when viewing live #1404

Closed reef-actor closed 1 month ago

reef-actor commented 2 months ago

Checklist:

Release with the issue: 5.2.0

Last working release (if known):

Browser and Operating System: Chrome (Windows/Android)

Description of problem: Enabling the Download button in the Menu section displays the download button always. The Download button should only be displayed when viewing something that can be downloaded, not when viewing live.

dermotduffy commented 2 months ago

If you click it, it's downloading the media from the thumbnail carousel (usually the latest clip or snapshot). I agree that's unintuitive and the thumbnails can optionally have their own download icons anyway.

reef-actor commented 2 months ago

I found with the download button on the thumbnails I was accidentally pressing it often when browsing the thumbnails, which is why I changed to the Menu button.

Perhaps it makes sense to move the download button from Menu to Media Viewer?

dermotduffy commented 2 months ago

I'll just remove the download button from the live view.