dermotduffy / frigate-hass-card

A Lovelace card for Frigate in Home Assistant
MIT License
485 stars 55 forks source link

full screen switch from sub not working #1479

Open jameseck opened 1 week ago

jameseck commented 1 week ago

Hi,

I'm using the latest version of Home Assistant, 2024.6.4 and the latest version of this card 5.2.0.

I have the below card config and the behaviour I'm expecting is:

What actually happens is: the card flickers into full screen, then the whole dashboard reloads and displays as normal (with no full screen).

I am using gortc within frigate and am exposing two streams front_sub (sub stream) and front (main stream). Both streams work independently with this card, but when I combine the two in a single card with the config below, the issue occurs.

I've tried this with multiple different browsers, on different clients - the behaviour is always the same. I'm sure there is something wrong with my config but I can't see it.

type: custom:frigate-card
view:
  actions:
    double_tap_action:
    action: custom:frigate-card-action
    frigate_card_action: fullscreen
cameras:
- camera_entity: camera.front
  id: front_sub
  live_provider: go2rtc
  go2rtc:
      modes:
      - webrtc
      stream: front_sub
  dependencies:
    cameras:
    - front_hd
- camera_entity: camera.front
  title: front HD
  live_provider: go2rtc
  go2rtc:
    modes:
    - webrtc
  id: front_hd
  hide: true
menu:
  buttons:
    substreams:
    icon: mdi:high-definition
automations:
- conditions:
    fullscreen: true
  actions:
  - action: custom:frigate-card-action
    frigate_card_action: live_substream_on
  actions_not:
  - action: custom:frigate-card-action
    frigate_card_action: live_substream_off
digitalpixies commented 3 days ago

Can you first try to resize your browser to fullscreen first and then retry? I have same problem but only when browser is not in fullscreen state. I've noticed a problem clicking on calendar button (typically renders bottom right when not fullscreen, so fullscreen just doesn't render it) while viewing timeline in fullscreen mode so there's probably a number of things that needs to be re-tested with the fullscreen mode/state.

jameseck commented 3 days ago

Thanks for the tip, but unfortunately I also see the same issue when the browser is in full screen. I've been testing this both on my desktop and on a dedicated Linux mini SFF pc with HDMI touchscreen that I use as a wall dashboard - results are the same for both. The dashboard pc runs in full screen, kiosk mode.