Closed dermotduffy closed 2 years ago
π HACS repository validator action summary π β The repository is not archived β hacs.json has the 'name' key set β The repository has a description β The repository has topics β The repository has issues enabled β This day ends with an 'y' (Monday) β README.md exists β Information file has images βͺ Ignored check: hacs
Just curious, is this ready for testing? I'd be happy to clone it into my HA and give feedback if anything comes up
Hi @NickM-27 -- thanks for the interest and offer to help! It's getting closer, and I'm very actively working on finishing up this PR. Maybe give it a few days, and hopefully I'll get this merged in -- then I'd really welcome that testing (before I do a new official build). Thanks again.
@dermotduffy sure sounds good! Would the best way to do it be to take everything in src/ and put that in the Lovelace directory? I just noticed official releases have a js.gz file instead of all the separate files.
@NickM-27 Best bet would be to build it yourself (https://github.com/dermotduffy/frigate-hass-card#building) and use that output. I can also attach a js.gz file to this PR when it's done to make that simpler.
@dermotduffy Ah! Didn't see that at the bottom, feel free to include but I'll be able to build it myself no problem
@dermotduffy I know this is still a WIP but I finished work early today and decided to give this branch a gander. I have to be honest it has been very positive!
The auto-migration worked well, swiping between my 3 cameras is smooth on all platforms and the lazy loading is still quite quick. Previously I had 3 frigate cards on the same dashboard page and it was pretty often that at least one would stay a white screen and not load, but with this single card I have not experienced that issue. The camera-switcher button is also very helpful when I am viewing clips as well!
The only thing I have found so far (you may be aware of it, but figured I would just mention it) is if I am viewing clips and use the camera switcher to view clips from another camera, there is a <- (back button) card that appears first. However, when I press that back button card it disappears and the clips remain the same instead of loading the clips from the previously selected camera. π
In any case, I am quite happy and so far with my setup things have been working great.
Hi @NickM-27 . Fantastic! Thank you for the testing. I didn't know about the 'back button' issue, I'll look into that. There are a few other things I need to also wrap up, but it's getting pretty close.
@NickM-27 For whatever reason I cannot reproduce the "Back button" issue you describe. Here's what I do:
At this point, as per your bug report, I'd expect to have the back button stay there -- but I don't, it disappears and is replaced with the clips of the new camera (which is what I'd expect).
Help?
@dermotduffy I am not drilling down that may be the difference. I'll attach a screen recording so you can see.
@NickM-27 Huh. Weird, I still cannot reproduce that even without the drill down and I don't think I changed anything in this part of the code since you tested. Mind pasting your config?
Just to remove a variable, I have been re-building to keep my card up to date with your commits so that isn't a concern.
type: custom:frigate-card
view:
default: live
menu:
mode: below
buttons:
frigate: false
frigate_ui: true
snapshots: false
image: false
clips: true
download: true
fullscreen: true
live: true
live:
preload: true
controls:
thumbnails:
mode: none
next_previous:
style: none
controls:
thumbnails:
mode: below
media: clips
event_viewer:
controls:
next_previous:
style: none
thumbnails:
mode: below
dimensions:
aspect_ratio_mode: dynamic
cameras:
- camera_entity: camera.front_doorbell_cam
frigate_url: http://192.168.50.106:5000
live_provider: frigate-jsmpeg
- camera_entity: camera.backyard_cam
frigate_url: http://192.168.50.106:5000
live_provider: frigate-jsmpeg
- camera_entity: camera.office_cam
frigate_url: http://192.168.50.106:5000
live_provider: frigate-jsmpeg
Okay scratch that last comment, it is happening on all devices. I just had a brain fart.
@dermotduffy also I followed your steps and the back button remained after switching cameras. I wonder if one of my configs is weird?
@NickM-27 OK, if I use your whole config, with my cameras
, I can reproduce it! Leave it with me.
Update: Something to do with live.preload
.
Huh, never would have thought preload was the culprit. Glad I was able to help
Okay that fixed the back button bug for me π I haven't found anything else either
@NickM-27 Great, thanks for rechecking, it was a subtle one -- but getting your exact config was the key thing to make progress, so thanks for that.
This PR is now pretty close...
Add support for multiple cameras:
overrides:
configuration section).Significant configuration changes required. Automated upgrade is available for visual editor users, for YAML users manual update is required using the following transition guide: