search

dermotduffy / frigate-hass-card

A Lovelace card for Frigate in Home Assistant
MIT License
477 stars 53 forks source link

'Live' popup repeats continuously #839

Closed cwelsh1812 closed 1 year ago

cwelsh1812 commented 1 year ago

Checklist:

Release with the issue: v4.0

Last working release (if known):v3.0

Browser and Operating System:

Description of problem:

Javascript errors shown in the web inspector (if applicable):

Additional information:

https://user-images.githubusercontent.com/42767976/192262726-7af90132-bbce-4b0b-b8f3-cc2c58c98092.mov

dermotduffy commented 1 year ago

Interesting! Can you hold down the Frigate menu button and paste the diagnostics? Are you using card_mod or anything else that may impact the normal rendering?

dermotduffy commented 1 year ago

PS: You can turn off the title popups temporarily from the card edit window, as that's pretty annoying.

cwelsh1812 commented 1 year ago

{ "ha_version": "2022.9.6", "card_version": "4.0.0", "browser": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36", "date": "2022-09-26T14:31:53.554Z", "frigate_version": { "3558a38c907f2eee9a5d638d31a59135": "3.0.0/0.11.0-3846a13" }, "lang": "en", "git": { "build_version": "4.0.0-HEAD+ge5a0bf4", "build_date": "Fri, 23 Sep 2022 00:27:16 GMT", "commit_date": "Thu, 22 Sep 2022 16:53:03 -0700" }, "config": { "type": "custom:frigate-card", "cameras": [ { "camera_entity": "camera.driveway", "live_provider": "webrtc-card" } ], "menu": { "style": "hidden", "position": "bottom", "buttons": { "live": { "enabled": true } } }, "live": { "controls": { "title": { "duration_seconds": 2 } } } } }

cwelsh1812 commented 1 year ago

I don't seem to be able to find the setting to turn off the title popup ?

dermotduffy commented 1 year ago

I don't seem to be able to find the setting to turn off the title popup ?

no-titles

PS: You are specifying webrtc-card as your live provider, but have not specified any webrtc card configuration, which is not a valid combination (either choose a different live provider, or include the details required for the webrtc-card provider). Not suggesting this is the trigger for the bug, but it could be:-)

webrtc

cwelsh1812 commented 1 year ago

Thanks. I have specified the web-rtc card config now and it has made no change.

Sarah-Connelli commented 1 year ago

I have the same issue now and again. Is it at all possible to just disable those message-toasts altogether? I never liked them in my use-case and often get in the way when you want to watch a recording and fullscreen it straight away, ie have to wait till the floating message goes away before being able to click fullscreen/volume etc on the player bar.

cwelsh1812 commented 1 year ago

Hi Sarah, if you see the post above you will see where to disable the pop ups, I have done this for the moment.

dermotduffy commented 1 year ago

@cwelsh1812 Mind answering this one:

dermotduffy commented 1 year ago

@cwelsh1812 One more: Can you try the HA live provider and see if it still happens?

cwelsh1812 commented 1 year ago

@dermotduffy Yes I have card-mod installed though I have not made any changes to the frigate card.

It does not happen with the HA live provider.

cwelsh1812 commented 1 year ago

@dermotduffy Ok, after deleting the cards and creating new ones, it's now not happening, although it does still happen on the preview of the card configuration page.

dermotduffy commented 1 year ago

@cwelsh1812 Thanks! Would it be possible to remove card_mod temporarily and see if it still happens? My guess is that it is related.

It does not happen with the HA live provider.

So just webrtc-card then? Thanks, this narrows it down a lot.

cwelsh1812 commented 1 year ago

@cwelsh1812 Thanks! Would it be possible to remove card_mod temporarily and see if it still happens? My guess is that it is related.

It does not happen with the HA live provider.

So just webrtc-card then? Thanks, this narrows it down a lot.

Sorry for the delay, I have removed card-mod and it still happens, although it is inconsistent, sometimes I can get it to happen on the live display in the dashboard, other times it only happens on the card preview.

crankin91 commented 1 year ago

I'm experiencing the same issue, also webrtc-card. It happens immediately after reload. Let me know if I can provide any other details.

dermotduffy commented 1 year ago

Whilst working on #861 I found a bug that causes the image view to proclaim new media has been loaded repeatedly, which causes these toast messages to repeatedly show up. This is now fixed in code.

My theory is that this is responsible for the behavior we are seeing here, under the following conditions:

... in this case, since the webrtc element doesn't render, the card shows a static image waiting for it to load. That image refreshes every 1 seconds, and with the above bug (now fixed, but not in a build yet) that causes the toast message to repeatedly appear.

To confirm this theory, please try either:

live:
  show_image_during_load: false

... (if my theory is correct you'll just see a forever spinning 'Waiting for WebRTC card to load' message.

cwelsh1812 commented 1 year ago

You are correct, forever spinning message !

dermotduffy commented 1 year ago

Thanks @cwelsh1812! So I think I'll mark this as fixed, since the underlying image component will now no longer exhibit this behavior from the next build (but you still have a separate webrtc problem that is not related to Frigate!).

Feel free to re-open if you / anyone thinks I've missed something here!

keteflips commented 1 year ago

I dont use webrtc and the spining message its my problem too.