derogab / coingraph

Coingraph is a real-time graph for cryptocurrencies that fetches real-time cryptocurrency prices, saves the data offline in a JSON file at regular intervals, and displays it through a minimalistic graph on a web interface.
MIT License
127 stars 18 forks source link

Replace Apache with a simple Python WebServer #2

Closed derogab closed 7 years ago

derogab commented 7 years ago

A developer on hacker-news made me notice that coingraph uses too many dependencies that can be replaced with home-made alternatives.

One of these is the web server. Now I use Apache, but it would be nice to replace it with a python web server.

gmemstr commented 7 years ago

Currently working on looking into this - looks like PHP also has a built in webserver which could help.

Edit: I'm just going to port over the PHP functions to a Python script and see how it does, going to build it with Tornado if WebSocket support is something you may be interested in in the future.

derogab commented 7 years ago

Cool. I have never used Tornado, but I will definitely read the documentation.

So are you working to replace Apache with Tornado?

gmemstr commented 7 years ago

@derogab Yup - replacing all the PHP so it should be all independent.

derogab commented 7 years ago

Wow. I look forward to your commit.

gmemstr commented 7 years ago

Ported most of the functionality of the PHP file to Python but it doesn't seem to get the right value from the database (price returns as usd for some reason). Looking into it but will hopefully have the PR open by tomorrow night. Also will make some tweaks to main.js if needed to parse results (should they differ from PHP results).

gmemstr commented 7 years ago

3 fixes this issue.