search TXID in all tokens history

Slixe commented 1 year ago

Description

RPC Method get_transfer_by_txid only search and work for DERO native token while we may want to query all our history including others tokens.

This PR allows to specify for which token we want to research and fallback to search in all if SCID is DERO one and no result was found.

Type of change

Please select the right one.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This will require a HardFork to be enabled

Which part is impacted ?

[X] Wallet
[ ] Daemon
[ ] Miner
[ ] Explorer
[ ] Simulator
[ ] Misc (documentation, comments, text...)

Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings

License

Im am contributing & releasing the code under DERO Research License (which can be found here).

CaptainDero commented 1 year ago

Why returning SCID if it is already a function argument ?

Slixe commented 1 year ago

Why returning SCID if it is already a function argument ?

Because if we search in default SCID (DERO) and we find the Entry for another token, then we returns in which SCID it got found as rpc.Entry don't have this knowledge.

CaptainDero commented 1 year ago

Ok. Thanks.

deroproject / derohe