Please include a summary of the changes and the related issue.
NOTE: The process is the following:
Your pull request should be directed to dev branch.
When it will be merged in dev, we will merge it to testnet for tests, and then into main for final release.
Fixes # (issue)
Type of change
Please select the right one.
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This will require a HardFork to be enabled
Which part is impacted ?
[x] Wallet
[ ] Daemon
[ ] Miner
[ ] Explorer
[ ] Simulator
[ ] Misc (documentation, comments, text...)
Checklist:
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
License
I'm am contributing & releasing the code under DERO Research License (which can be found here).
Summary
Wallet entries list one's wallet address for incoming transactions if the ringsize is greater than 2.
The sender index is determined by sender_idx := uint(tx.Payloads[t].RPCPayload[0]) and isn't touched again for ringsizes > 2.
RPCPayload[0] always contains the receiver index. The values is placed there during transaction creation.
GetTransferbyTXID, GetTransfers and the exported wallet history are affected.
I recommend leaving the "sender" field blank for such transactions to avoid confusion, as the sender cannot be determined.
Description
Please include a summary of the changes and the related issue.
NOTE: The process is the following:
devbranch.dev, we will merge it totestnetfor tests, and then intomainfor final release.Fixes # (issue)
Type of change
Please select the right one.
Which part is impacted ?
Checklist:
License
I'm am contributing & releasing the code under DERO Research License (which can be found here).
Summary
Wallet entries list one's wallet address for incoming transactions if the ringsize is greater than 2. The sender index is determined by
sender_idx := uint(tx.Payloads[t].RPCPayload[0])and isn't touched again for ringsizes > 2.RPCPayload[0]always contains the receiver index. The values is placed there during transaction creation. GetTransferbyTXID, GetTransfers and the exported wallet history are affected. I recommend leaving the "sender" field blank for such transactions to avoid confusion, as the sender cannot be determined.