Open derpachu opened 7 years ago
Looks beautiful! 🌟 As a fan of both the Sim City games and Cities: Skyline, I look forward to this next evolution in the genre. 😄 I only have a couple notes regarding the table:
<table>
<tr>
<th></th>
<th>number of cities</th>
<th>number of catastrophes</th>
</tr>
<tr>
<td>this game</td>
<td>8</td>
<td>32</td>
</tr>
<tr>
<td>Simcity</td>
<td>1</td>
<td>8</td>
</tr>
<tr>
<td>cites: skyline </td>
<td>4</td>
<td>0</td>
</tr>
</table>
table
The elements inside the table
element are not indented further, to indicate they're children.
thead
This row only includes headings for the entire table:
<tr>
<th></th>
<th>number of cities</th>
<th>number of catastrophes</th>
</tr>
So semantically, it would probably be best to wrap it with a thead
element, then put the rest of the rows in a tbody
element.
th
element(s)The first column (containing this game
, Simcity
, and cities: skyline
) doesn't have a heading of its own, indicating that this is probably a column of headings. For this reason, I would either:
th
elements instead of td
elements, ORName
in the top rowLet me know if you have any questions or when the code is ready for another look. 🙂
reupdated the table to fix issues
Very nice! 🎉 👍 🎈 :shipit:
@chrisvfritz Can you take a look at this? It's hosted here and meets the following criteria:
br
elements to add new lines where appropriate)let me know if anything is not up to standards