derpibooru / philomena

Next-generation imageboard
https://derpibooru.org/
GNU Affero General Public License v3.0
219 stars 56 forks source link

`https://derpibooru.org/session/new` produces message `You can't access that page.` #168

Closed mathieucaroff closed 4 years ago

mathieucaroff commented 4 years ago

Bug description

Trying to login to a derpibooru account requires connecting to the below url:

https://derpibooru.org/session/new

but this is not possible and a server redirection 302 to derpibooru.org/ happens.

To Reproduce

Steps to reproduce the behavior:

A1. Go to derpibooru.org on a browser where you aren't logged in A2. Try to upvote or fave or downvote any image

Or alternatively:

B1. Go to https://derpibooru.org/session/new on a browser where you aren't logged in

Screenshots

(site after trying to perform any action which requires to login)

image

Desktop (please complete the following information):

Internet providers

Additional context

++ issue search keywords: login, signin, sign-in, connect

mathieucaroff commented 4 years ago

So talking with friends showed that clicking on the "Login" button did lead to the correct url: https://derpibooru.org/session**s**/new

and also, that my userstyle actually hid the "Login" button in Firefox.

So I believe the fix would be to either:

liamwhite commented 4 years ago

https://github.com/philomena-dev/philomena/commit/a81464f189fe3c196e74997d432fa0eeb1a38d0f

mathieucaroff commented 4 years ago

I believe that to rule out a whole category of bugs which includes this last one, philomena should consider using https://en.wikipedia.org/wiki/Single_source_of_truth more, though it is usually hard to pass information from the backend to the frontend in a type-checked way. I one way to go about that is using JSON as single source of truth.