Closed FannyMonteiro closed 9 months ago
The code changes are basically limited to ECOGEM. Please run some (ideally published) ECOGEM experiments you have previous carried out ... check that the results are the same under branch DEV_GMD23 as before.
Hi Andy,
I just launched two ecogem experiments from Cermeno et al., for 5000 years, on master and the new development branch. I should be able to check the results on Monday.
– Alex
I have set two 1k year simulations off on master and Dev_gmd23...
thanks!
Hi Andy,
I just launched two ecogem experiments from Cermeno et al., for 5000 years, on master and the new development branch. I should be able to check the results on Monday.
– Alex — Reply to this email directly, view it on GitHub, or unsubscribe . You are receiving this because you commented.
thanks!
I have set two 1k year simulations off on master and Dev_gmd23... — Reply to this email directly, view it on GitHub, or unsubscribe . You are receiving this because you commented.
Hey,
Here are the results after 5 Kyrs: https://cloud.u-bourgogne.fr/index.php/s/ofdsJayHE55CX5r
I did notice a slight change in export prod / [PO4], see Figs. 14 and 18 in the PDF summary file of the difference. I don’t know if that’s expected, or not, and then I also put the simulation results in the archive as well so you can have a look.
– Alex
Hi, I ran ecogem for 1000 years with 1 plankton size class and PO4 ony (no Fe). The output files differ, but the values for 6 variables in the attached are numerically identical.
Ben
From: Alexandre Pohl @.> Date: Monday, 27 November 2023 at 08:23 To: derpycode/cgenie.muffin @.> Cc: Ben Ward @.>, Review requested @.> Subject: Re: [derpycode/cgenie.muffin] Dev gmd23 (PR #233) CAUTION: This e-mail originated outside the University of Southampton. Hey,
Here are the results after 5 Kyrs: https://cloud.u-bourgogne.fr/index.php/s/ofdsJayHE55CX5r
I did notice a slight change in export prod / [PO4], see Figs. 14 and 18 in the PDF summary file of the difference. I don’t know if that’s expected, or not, and then I also put the simulation results in the archive as well so you can have a look.
– Alex
— Reply to this email directly, view it on GitHubhttps://github.com/derpycode/cgenie.muffin/pull/233#issuecomment-1827346960, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG2OSW2ZGU45UOD3V5JMD33YGREWTAVCNFSM6AAAAAA7WUYYVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXGM2DMOJWGA. You are receiving this because your review was requested.Message ID: @.***>
The circultion is very slightly different ... so any biogeochem differences could simply be due to that. hard to tell.
/andy
Hey,
Here are the results after 5 Kyrs: https://cloud.u-bourgogne.fr/index.php/s/ofdsJayHE55CX5r
I did notice a slight change in export prod / [PO4], see Figs. 14 and 18 in the PDF summary file of the difference. I don’t know if that’s expected, or not, and then I also put the simulation results in the archive as well so you can have a look.
– Alex — Reply to this email directly, view it on GitHub, or unsubscribe . You are receiving this because you commented.
Ran some worjh2 PO4-only experiments, for 1000 years from a non ECOGEM restart. The small ECOGEM differences seemed to be associated with the small differences in esp. sea-ice in the seasonal worjh2 config. Unclear from everyone's testing whether there are any differences beyond those that might be expected from small differences in ocean circulation and sea-ice cover. I am pushing the merge through. People should simply be aware that we do not have 100% certainty that there are no changes at all in ECOGEM behavior as a result fo the code changes. If there are, they are very minor indeed.
New code for EcoGEnIE 1.1 (Naidoo-Bagwell et al., GMD, 2023), which includes the implementation of phytoplankton functional groups diatoms, picophytoplankton and eukaryotes On branch DEV_GMD23 new file: genie-ecogem/data/input/3Diat_4ZP_PiEu.eco modified: genie-ecogem/src/fortran/ecogem.f90 modified: genie-ecogem/src/fortran/ecogem_box.f90 modified: genie-ecogem/src/fortran/ecogem_data.f90 modified: genie-ecogem/src/fortran/ecogem_lib.f90 modified: genie-ecogem/src/fortran/initialise_ecogem.f90 new file: genie-main/configs/muffin.CBE.worjh2.BASESFeTDTLSi.Albani.config modified: genie-main/src/xml-config/xml/definition.xml new folder: genie-userconfigs/PUBS/submitted/Naidoo-Bagwell_et_al.GMD.2023