search

derpycode / cgenie.muffin

MIT License
38 stars 26 forks source link

Day length #241

Closed Camillalxy98 closed 8 months ago

Camillalxy98 commented 9 months ago

Parameterization of solar day length and sidereal day length added to goldstein, goldstein-seaice and embm to replace the hard-coded "86400" s/day to enable simulations with day length/rotation rate different from Earth's present 24 hour day. Sidereal day length is now used in calculation of Coriolis related parameters.

derpycode commented 9 months ago

Camilla Liu, working with Steph Olson, has made changes to enable the day length to be changed. Camilla's branch is already up-to-date with master, which includes the recent orbits changes. So the question is whether anything in the day length change changes the new orbits behavior, although it is worth double-checking what the old orbits code is also un-changed.

alexpohl commented 9 months ago

Hey,

Happy to let Pam or Sandy check since they know best that kind of orbit stuff, but I can have a look otherwise.

– Alex

derpycode commented 8 months ago

Going to cancel this for now ... update from master to master.daylength and then see if I can find where something has changed.