search

derrickpelletier / react-loading-overlay

Loading overlays with fade, spinner, message support.
MIT License
256 stars 84 forks source link

Custom style on LoadingOverlay #17

Closed AllenFang closed 5 years ago

AllenFang commented 6 years ago

HI @derrickpelletier firslty, thanks this awesome repo, I'm going to use it in my site prodject, however, I found seems like we can not custom the styles on LoadingOverlay component: https://github.com/derrickpelletier/react-loading-overlay/blob/master/src/LoadingOverlay.js#L93

If yes, I think it will be useful to have this customization feature and I can open a PR for it How do you said?

Regards, Allen

derrickpelletier commented 6 years ago

Would love for it to be more customizable!

On Sat, Dec 2, 2017 at 2:04 AM Allen notifications@github.com wrote:

HI @derrickpelletier https://github.com/derrickpelletier firslty, thanks this awesome repo, I'm going to use it in my site prodject, however, I found seems like we can not custom the styles on LoadingOverlay component: https://github.com/derrickpelletier/react-loading-overlay/blob/master/src/LoadingOverlay.js#L93

If yes, I think it will be useful to have this customization feature and I can open a PR for it How do you said?

Regards, Allen

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/derrickpelletier/react-loading-overlay/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/AAy3ksQFRUDF6GTwJ8ZaKG3_mEWfNgbZks5s8SClgaJpZM4QzP_F .

AllenFang commented 6 years ago

@derrickpelletier coool, I'll make a PR for this, if the props name isoverlayStyle is that ok for you?

Thanks your quick response 👍