search

derrickpelletier / react-loading-overlay

Loading overlays with fade, spinner, message support.
MIT License
256 stars 84 forks source link

add position props support #29

Closed tkforce closed 5 years ago

tkforce commented 5 years ago

I was using this awesome loading overlay as a global overlay for our SPA project, but with the position:absolute property, the loading spinner and the text will be centered in the scope of entire page rather than the viewing window. I'd suggest we add a position property to the props so that user can adjust accordingly, Thanks!

derrickpelletier commented 5 years ago

Hi @tkforce, thanks for your PR. I had half built new implementation of the whole thing already underway so unfortunately i won't be merging this.

Appreciate it though.

But on the bright side you should be able to fully style everything now :)

tkforce commented 5 years ago

Awesome! Thanks for the update @derrickpelletier =)