search

derrickpelletier / react-loading-overlay

Loading overlays with fade, spinner, message support.
MIT License
256 stars 84 forks source link

Usage of React's Legacy Context API throws an error in Console #43

Open kevin-guertin opened 4 years ago

kevin-guertin commented 4 years ago

This project uses React's Legacy Context API and needs to be updated to use the new Context API so it does not throw an error in console.

https://reactjs.org/docs/context.html#legacy-api

image

arielspalter commented 4 years ago

second that!

dennisMeeQ commented 4 years ago

third that! I also get: image

arielspalter commented 4 years ago

You guys can check out a better option: https://www.npmjs.com/package/react-element-spinner

derrickpelletier commented 4 years ago

Dang! Check out the one @arielspalter linked if you need something.

btw always willing to accept PRs for these issues.

Victorvhn commented 4 years ago

Hello guys, I open a PR #46 with what I think is the fix for the problem. I would be very happy if it is approved, because today I am using a fork version of this implementation, and I would like to use the original. @derrickpelletier

kevin-guertin commented 4 years ago

Dang! Check out the one @arielspalter linked if you need something.

btw always willing to accept PRs for these issues.

Can you please accept the above PR?

obouchari commented 4 years ago

Hello guys, I open a PR #46 with what I think is the fix for the problem. I would be very happy if it is approved, because today I am using a fork version of this implementation, and I would like to use the original. @derrickpelletier

@Victorvhn Could you please share your fork as an independent package under different name? I don't think this package is actively updated.

Victorvhn commented 3 years ago

Hello guys, I open a PR #46 with what I think is the fix for the problem. I would be very happy if it is approved, because today I am using a fork version of this implementation, and I would like to use the original. @derrickpelletier

@Victorvhn Could you please share your fork as an independent package under different name? I don't think this package is actively updated.

Sorry for the delay, follow the link https://github.com/Victorvhn/react-loading-overlay https://www.npmjs.com/package/fork-victorvhn-react-loading-overlay