derricksmith / phpsaml

GLPI Plugin - SAML integration using the Onelogin SAML Library
MIT License
32 stars 24 forks source link

Function libxml_disable_entity_loader() is deprecated using on 10.0.3 #107

Open pablitobin opened 2 years ago

pablitobin commented 2 years ago

Hi Derrick. I am using the plugin on GLPI 10.0.3 on PHP8 and it was working until yesterday. I am getting this error now when I try to login:

Deprecated: Function libxml_disable_entity_loader() is deprecated in xxxxxxxx\plugins\phpsaml\lib\php-saml\src\Saml2\Utils.php on line 88

Deprecated: Function libxml_disable_entity_loader() is deprecated in xxxxxxxx\plugins\phpsaml\lib\php-saml\src\Saml2\Utils.php on line 90

Loopers29 commented 2 years ago

hi pablitobin, how can you use this plugin with GLPI version 10.0.3 when version 1.2.0 of phpsaml does not allow it yet ?

pablitobin commented 2 years ago

Just avoid version restriction.

On Thu, Oct 13, 2022, 2:54 PM vfvjwork @.***> wrote:

hi pablitobin, how can you use this plugin with GLPI version 10.0.3 when version 1.2.0 of phpsaml does not allow it yet ?

— Reply to this email directly, view it on GitHub https://github.com/derricksmith/phpsaml/issues/107#issuecomment-1277564269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUGLQ4MNOOIMODHOJYPOJTWDABBLANCNFSM6AAAAAAQ5IYX6I . You are receiving this because you authored the thread.Message ID: @.***>

derricksmith commented 2 years ago

Hi Derrick. I am using the plugin on GLPI 10.0.3 on PHP8 and it was working until yesterday. I am getting this error now when I try to login:

Deprecated: Function libxml_disable_entity_loader() is deprecated in xxxxxxxx\plugins\phpsaml\lib\php-saml\src\Saml2\Utils.php on line 88

Deprecated: Function libxml_disable_entity_loader() is deprecated in xxxxxxxx\plugins\phpsaml\lib\php-saml\src\Saml2\Utils.php on line 90

This issue is resolved in php-saml library 4.0. Since this is a major change for this plugin, I'll put it on the roadmap for version 1.3.

hi pablitobin, how can you use this plugin with GLPI version 10.0.3 when version 1.2.0 of phpsaml does not allow it yet ?

The PLUGIN_PHPSAML_MAX_GLPI was increased in 1.2.1

derricksmith commented 2 years ago

Updated phpsaml library in 1.3.0 branch. Performed cursory tests. No errors