[SUGGESTION] Option to change the SSO button label

derricksmith / phpsaml

GLPI Plugin - SAML integration using the Onelogin SAML Library

MIT License

32 stars 24 forks source link

[SUGGESTION] Option to change the SSO button label #126

Open GraphicHealer opened 1 year ago

GraphicHealer commented 1 year ago

Hello there,

I think if we could change the text on the SSO button on the login page that would be great. Alot of people do not know what "SSO" is, and will not know what to do on that page. If instead, we could rename it to whatever SSO provider we are using, that would simplify and clarify what button the user is supposed to click.

For example, I went to this line: https://github.com/derricksmith/phpsaml/blob/988157eb826e44bccfc8b96c8b3c8e468494e1a2/setup.php#L244 and changed the button label to "Sign in with Teams/Outlook" because that would make the most sense to the users where I work.

If this could be done programmatically in the settings page for PHPSAML, that would be great.

Thanks, G

DonutsNL commented 1 year ago

Added this feature to the rule-engine branch I am working on. https://github.com/derricksmith/phpsaml/pull/118/commits

Beware this branch is not stable yet.

GraphicHealer commented 1 year ago

Cool!

Another quick question, I see you have the same issue from the screenshot. Is there any way to get that SSO button to show up UNDER the login fields? It keeps showing off to the right, and it messes up the whole layout. It would look better if it was underneath.

GraphicHealer commented 1 year ago

I found the problem! Turns out the code in GLPI is weird. https://github.com/DonutsNL/glpi/blob/9d645ddde56b7170760ac090c3639b0c5613b85d/templates/pages/login.html.twig#L122

This line is what triggers the plugins to know that GLPI has drawn the login page, and allows them to drop in extra HTML. It is actually too late to add anything useful, and it would be great if it was moved to line 94. Then it would trigger right at the bottom of the login form, rather than of to the side.

I may put an issue in to GLPI to see if they might fix it.

DonutsNL commented 1 year ago

Dont register an issue with GLPI because the location is not an bug or issue.

Its is the default location when looking at the login screen using landscape orientation (devices with wider screens). When you open it on a mobile device with a smaller screen the button is actually located underneath the GLPI login box.

It currently looks kinda funky because we did not spend time to beautify the saml login box. Its just a button without any layout (yet).

GraphicHealer commented 1 year ago

It still seems that this was not intended, as even the FAQ shows up to the side, and makes the whole page funky. This is an easy fix, of just a few lines of code. I think GLPI would benefit from this.

Also, if I do post the issue, they can always say that is was intended, and just hadn't been prettyified yet.