search

derrix060 / onedriveClient

A Microsoft OneDrive and OneDrive for Business client for Linux, written in Python3.
MIT License
65 stars 10 forks source link

Remove f-strings or import it from future #47

Closed derrix060 closed 4 years ago

derrix060 commented 5 years ago

F-strings were introduced on python 3.6 but this project is compatible with python 3.4 +.

Rather remove all f-strings and manually replace it, or use this project

modelmat commented 5 years ago

Whilst I believe f-strings are much better and cleaner than the .format style, the future-fstrings project seems a little dodgy and (not that I have seen any) likely to break. I think we should use that project's cli script to generate .format style files and continue to use them.

sameshl commented 5 years ago

@derrix060 I would like to work on this. So if I understand correctly, I am supposed to remove all f-strings and manually replace it with .format style?

modelmat commented 5 years ago

You could manually replace it or using the future-fstrings project's CLI tool for converting f-strings to format-strings and then replace the updated files.

So, yes.

sameshl commented 5 years ago

I tried grepping but couldn't figure out a way for manually finding all the f-strings. can you help me out @Modelmat

modelmat commented 5 years ago

Take a look at https://github.com/asottile/future-fstrings#showing-transformed-source

derrix060 commented 5 years ago

Sorry for the delay, I was on holidays.

Thanks for the interest @sameshl. Yes, the idea is changing the f-strings (f'... {var} ...') to .format style ('... {} ...'.format(var))

gauravdoodles commented 4 years ago

use import from future to make it compatible with python 3.6

RobatBender commented 4 years ago

i didnt find any f-string, please show me

derrix060 commented 4 years ago

@RobatBender you're right, someone might have done it already.