search

derrod / legendary

Legendary - A free and open-source replacement for the Epic Games Launcher
https://legendary.gl/discord
GNU General Public License v3.0
4.56k stars 160 forks source link

Epic Games formerly listed by Legendary now delisted? #633

Open Darthagnon opened 7 months ago

Darthagnon commented 7 months ago

Platform

Operating system and version: Win10 Legendary version (legendary -V): legendary version "0.20.34", codename "Direct Intervention"

Expected Behavior

I've been keeping a list of my games claimed on Epic here, where I use Legendary's listing functions to export a list every couple of months.

Current Behavior

I recently updated Legendary, as I noticed an update prompt when I had to re-auth. I generated new lists with the latest Christmas 2023 giveaways from Epic, and updated my Epic Games list repo. In the diff, I noticed that a whole bunch of games are now missing from the list. A few I checked still seem to appear on the EGS as "In Library", but I was wondering what might be causing them to disappear from the list like this? Is it a bug in Legendary or some install behaviour changed?

Steps to Reproduce

  1. Run legendary list-games --csv >> epic-games.csv | legendary list-games >> epic-games.txt with the latest version of Legendary
  2. If you compare your new lists with previously generated lists, you will notice some games missing. They are not removed from the EGS account, delisted from the store or updated in any major way.
derrod commented 7 months ago

I do have a number of these games and they show up normally for me, so I don't really know what would be happening there.

Darthagnon commented 7 months ago

I don't know if this might be relevant, but when I'm using the commands via BAT file as usual, it prints a weird 1 in the console log (screenshot attached) and counts the games wrong. cmd_qnofIe4LP0

EDIT: The CSV seems to have generated correctly, but the txt file with "1 apps" (containing the shorter list) still seems to be missing the games. I regenerated it by running the command by itself, not as the second in the BAT file, and it then works.

Darthagnon commented 3 months ago

This still seems to be an issue, and now I'm getting the following errors when I try and run the list to file commands:

E:\Program Files\Games\legendary>legendary list-games --csv >> epic-games.csv
[cli] INFO: Logging in...
[Core] INFO: Trying to re-use existing login session...
[cli] INFO: Getting game list... (this may take a while)
[Core] INFO: Fetching metadata for 2 app(s).
Traceback (most recent call last):
  File "legendary\cli.py", line 3149, in <module>
  File "legendary\cli.py", line 3060, in main
  File "legendary\cli.py", line 200, in list_games
  File "legendary\core.py", line 476, in get_game_and_dlc_list
  File "legendary\core.py", line 449, in fetch_game_meta
TypeError: 'NoneType' object is not subscriptable
[10384] Failed to execute script 'cli' due to unhandled exception!

E:\Program Files\Games\legendary>legendary list-games >> epic-games.txt
[cli] INFO: Logging in...
[Core] INFO: Trying to re-use existing login session...
[cli] INFO: Getting game list... (this may take a while)
[Core] INFO: Fetching metadata for 2 app(s).
Traceback (most recent call last):
  File "legendary\cli.py", line 3149, in <module>
  File "legendary\cli.py", line 3060, in main
  File "legendary\cli.py", line 200, in list_games
  File "legendary\core.py", line 476, in get_game_and_dlc_list
  File "legendary\core.py", line 449, in fetch_game_meta
TypeError: 'NoneType' object is not subscriptable
[13512] Failed to execute script 'cli' due to unhandled exception!
derrod commented 3 months ago

This happened to me as well now with a game that has been removed from the store, deleting the assets.json file in your config directory may fix it.

user4302 commented 3 months ago

This happened to me as well now with a game that has been removed from the store, deleting the assets.json file in your config directory may fix it.

this worked for me, i am now able to list all the games instead of "1" game and i am also able to import a specific game that wasnt importing before

it seems like i have to do this each time i restart the pc in order to run legendary list

Darthagnon commented 2 months ago

Deleting Assets.json made Legendary work again. Looks like some Editors/SDKs have been removed from my account, and all the Mac section from Assets.json is now gone.

Accidentally commited a secret to my epic games list repo; I have removed it with bfg, but the historical commit still seems to be cached by Github, despite my rewriting history to remove it. I have set the repo to private for the time being.