Small doc fix: wrap does not ignore return_value

derwiki-adroll / mock

Automatically exported from code.google.com/p/mock

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Small doc fix: wrap does not ignore return_value #149

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Hi,
I think the first mention of return_value in the doc of the 'wrap' parameter of 
Mock is misleading.

Original issue reported on code.google.com by dirk.imp...@gmail.com on 30 Mar 2012 at 12:29

Attachments:

doc-contradiction.diff

GoogleCodeExporter commented 9 years ago

Original comment by dirk.imp...@gmail.com on 30 Mar 2012 at 12:45

Added labels: ****
Removed labels: ****

Attachments:

doc-contradiction.patch

GoogleCodeExporter commented 9 years ago

I know what you wanted to say, and simply deleting is probably not enough.  
It's just that I had to try it out to see what actually happens.

Maybe "return the result of the wrapped function from the mock"

Original comment by dirk.imp...@gmail.com on 30 Mar 2012 at 12:53

Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

Thanks for this.

Original comment by fuzzyman on 4 Apr 2012 at 10:17

Changed state: Accepted
Added labels: Type-Task
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

Original comment by fuzzyman on 4 Apr 2012 at 1:44

Added labels: Milestone-Release1.0
Removed labels: ****

GoogleCodeExporter commented 9 years ago

Applied to trunk. Many thanks.

Original comment by fuzzyman on 13 Apr 2012 at 7:53

Changed state: Fixed
Added labels: ****
Removed labels: ****