search

desandro / 3dtransforms

:package: Introduction to CSS 3D transforms
https://3dtransforms.desandro.com/
1.01k stars 163 forks source link

Added IE11 support to the Carousel 2 example #11

Closed 0xbrock closed 6 years ago

0xbrock commented 10 years ago

Sorry about the other pull request, I fixed the commit. Now it is only going to modify the files that actually changed.

I added functionality to the Carousel 2 example which allow your carousel to work in IE11. There is still an issue w/ the backface visibility, but if it is toggled off, it works as expected. I tested in IE10, but that did not work at all for me.

Thanks for your examples.

desandro commented 10 years ago

Thank you for this contribution! Looking it over, I'd rather have code that is re-usable. It appears you have inline styles, and MS-specific prefixes. Any chance you could integrate your solution, rather than adding it on top of the current code?

0xbrock commented 10 years ago

Good point. I did modifications from a browser Save As and those were there when I started making my changes and didn't think to remove them when I was merging.

I have removed the inline code and tested in IE11, FF and Chrome.

Also, it would be good to note somewhere that IE browsers will have a better experience if they use the carousel w/ backface invisible. While it "works", infinitely sliding yields some interesting visual effects. I have looked into fixing it but was not able to make progress on it. Since my needs didn't require the backface to be visible, I didn't pursue it further.