desandro / draggabilly

:point_down: Make that shiz draggable
https://draggabilly.desandro.com
MIT License
3.86k stars 386 forks source link

Added Typescript declaration file for the Draggabilly library. #109

Open giespaepen opened 9 years ago

giespaepen commented 9 years ago

Great library and I just needed dragging in a webproject without the need of the large jQueryUI library. Since I develop with Angular/Typescript it came in handy to create a declaration file. Feel free to merge it!

desandro commented 9 years ago

Thanks for this contribution. I don't have any experience with Typescript and Angular 2, so I'd like to wait and see if others are interested in adding this before I merge it in.

Add a 👍 reaction to this PR if you'd like to see this feature added to Draggabilly.

jhrdina commented 8 years ago

+1

amritk commented 8 years ago

+1

jackhayter commented 8 years ago

+1

p-mcgowan commented 8 years ago

+1

GarrisonJ commented 8 years ago

+1

mattleibow commented 8 years ago

Totally a +1!

corykon commented 8 years ago

+1

artemverbo commented 8 years ago

+1

chrismacp commented 8 years ago

+1

chrismacp commented 8 years ago

Not sure this declaration file works if you don't have JQuery though? It's referencing a JQuery directory which I don't have in my typings directory. Not sure what the best solution is as I'm just learning TypeScript.

j2jensen commented 8 years ago

Chrismacp makes a good point. I don't see why the jQuery reference at the top needs to be there anyway. It should work just fine without it.

What about adding this as a DefinitelyTyped entry while we wait to see if it gets accepted? I imagine most people who want jQuery typings are going to be pulling them from DefinitelyTyped anyway, right?

giespaepen commented 6 years ago

Sorry @desandro, forgot this PR completely. Still valid if I add some typings. Not that much effort nowadays.