search

desandro / imagesloaded

:camera: JavaScript is all like "You images done yet or what?"
https://imagesloaded.desandro.com
MIT License
8.88k stars 1.15k forks source link

MIT Template contains a placeholder for year and copyright #288

Closed surfmuggle closed 3 years ago

surfmuggle commented 4 years ago

I just noticed that the MIT template starts with:

Copyright <YEAR> <COPYRIGHT HOLDER>

Permission is hereby granted, free of charge, to any person [...] so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Now i understand why our legal team pointed out that a copyright notice is missing. I assume that the values for <YEAR> and <COPYRIGHT HOLDER> must be filled - see 102

surfmuggle commented 4 years ago

Hello @desandro , i just noticed that the copyright notice is included on this page https://desandro.mit-license.org/. I still believe that following githubs recomennetation would be a good thing:

Most people place their license text in a file named LICENSE.txt (or LICENSE.md) in the root of the repository; here's an example from Hubot.

[....]

As a best practice, we encourage you to include the license file with your project.

Cheers