search

desandro / jquery-bridget

:bridge_at_night: bridget makes jQuery plugins
108 stars 24 forks source link

Add jQuery as a dependency #3

Closed silvenon closed 10 years ago

silvenon commented 10 years ago

It was under devDependencies, while it should have been under dependencies, because it needs jQuery in order to work.

desandro commented 10 years ago

I've purposely left off jquery as an explicit dependency because how I like jQuery Bridget to work as an optional feature. For example, if you are using Masonry, and you want to use jQuery, it's there. But If you don't need jQuery, then it shouldn't be an explicit dependency.

silvenon commented 10 years ago

Ok. For me it's weird to include jquery-bridget if it's not going to do anything, I'd just ignore both jquery-bridget and jquery if I didn't want them. But since Bower doesn't support optional dependencies, I guess there's no perfect solution here :)

desandro commented 10 years ago

I realize it's weird and feels backwards. I appreciate you taking a look. I'd say this is up for discussion