search

desbma / GoogleSpeech

Read text using Google Translate TTS API
GNU Lesser General Public License v2.1
161 stars 37 forks source link

Only check binary dependency when audio is played #22

Closed user202729 closed 4 years ago

user202729 commented 4 years ago

In the current implementation, the audio is only loaded after play or output is called, so the check is done before the program make any HTTP request.

I don't have sox installed, but I have another audio player, and I want to use that, so it should not error out.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.09%) to 76.406% when pulling ac518ad79b217ba8f65a9d0f2ca35b748f6af98f on user202729:lazycheckbin into fbcd022b6e88b42ed7438395209b5429bf360826 on desbma:master.

desbma commented 4 years ago

I have removed the bin_dep check completely instead.

Users that are trying to play sound without SoX installed will get an error anyway.

And users that only want to download the sound don't need the check.