search

desbma / hddfancontrol

Regulate fan speed according to hard drive temperature
GNU General Public License v3.0
134 stars 17 forks source link

Min Fan Speed Setting not respected #14

Closed kgd192 closed 5 years ago

kgd192 commented 5 years ago

Even though I am running a min Fan Speed Setting the fan speed is still commanded below that threshold, at least according to the log. I am running the systemd service.

ARGS: --min-fan-speed-prct 10

LOG: Jan 13 16:04:19 nasty hddfancontrol[31549]: INFO [Main] Maximum drive temperature: 30 C Jan 13 16:04:19 nasty hddfancontrol[31549]: INFO [Fan #1] Setting fan speed to 0% Jan 13 16:04:39 nasty hddfancontrol[31549]: INFO [Main] Maximum drive temperature: 31 C Jan 13 16:04:39 nasty hddfancontrol[31549]: INFO [Fan #1] Setting fan speed to 5%

Cheers

kgd192 commented 5 years ago

After having looked at the code seems to be a logging Issue I suggest to change file __init__.py Line 322 from

self.logger.info("Setting fan speed to %u%%" % (speed_prct))

to

# Only show change in Logfile, when requested speed_prct is greater then min_prct
    if (speed_prct > min_prct):
      self.logger.info("Setting fan speed to %u%%" % (speed_prct))
desbma commented 5 years ago

Indeed, that logging statement is misleading.