Add a "loudest" album mode

desbma / r128gain

Fast audio loudness scanner & tagger (ReplayGain v2 / R128)

GNU Lesser General Public License v2.1

170 stars 9 forks source link

Add a "loudest" album mode #24

Closed gavtroy closed 3 years ago

gavtroy commented 3 years ago

Reference:

Recommendation for loudness normalization by Music Streaming Services -- Eelco Grimm, MLA member https://octo.hku.nl/octo/repository/getfile?id=qLlZPGSVXFM

I'm not sure how well it fits 128gain's goals, but I wanted this myself so I had a go at adding it.

Extending -a to accept a mode value seemed quite verbose, and making the value optional also wouldn't work well because it can't always be distinguished from the file argument. I just tacked on a new flag instead.

coveralls commented 3 years ago

Coverage decreased (-0.3%) to 74.679% when pulling d36a5390eb654dce20af99491a717abd4cf31fa0 on gavtroy:dev_album_loudest into aafe2526e836b6ded6e50eb439b7dfe8441c04ed on desbma:master.

coveralls commented 3 years ago

Coverage increased (+0.09%) to 75.046% when pulling 060fd6c2ae2a83b20d75478b1f2cb6e13ad3fa80 on gavtroy:dev_album_loudest into aafe2526e836b6ded6e50eb439b7dfe8441c04ed on desbma:master.

desbma commented 3 years ago

Thanks for taking the time to contribute this.

However I do not intend to merge this change.

This introduces a different meaning for the tag value (because of the different loudness algorithm), with the same tag file format so essentially an incompatible/competing tag. The tag landscape is already fragmented and the R128_XXX_GAIN is still niche, so I really want to avoid that.

gavtroy commented 3 years ago

That's fine, I was expecting exactly that response. Maybe the idea will gain traction and we'll eventually get something like a replaygain v3 out of it, but for now this is change probably a solution without a problem.

topas-rec commented 3 years ago

I read about that, too. That is why I use the album mode.