desbma / r128gain

Fast audio loudness scanner & tagger (ReplayGain v2 / R128)
GNU Lesser General Public License v2.1
170 stars 9 forks source link

aac louder mp3 #33

Closed MrGeorgen closed 2 years ago

MrGeorgen commented 2 years ago

I play the files with mpd and the tagged aac files are louder than the tagged mp3 files

desbma commented 2 years ago

Can you upload the same track as MP3 and AAC so I can look at it?

MrGeorgen commented 2 years ago

It did not tag the aac file at all. I must have overlooked it because I tagged an directory. I get the following output:

Unhandled 'AAC' tag format for file 'Leona Lewis - Bleeding Love (Official Video).aac'
File 'Leona Lewis - Bleeding Love (Official Video).aac': loudness = SKIPPED, sample peak = SKIPPED
desbma commented 2 years ago

Can you upload that file somewhere, so I can look at it?

MrGeorgen commented 2 years ago

yeah https://mega.nz/file/meQnwIwI#bLFl8APIw9LK9-b0C8NxbgBJx5d-WL_Nejp5jdeMQZw

desbma commented 2 years ago

Can you test commit https://github.com/desbma/r128gain/commit/ec3a7375decc46aefed537f4a2e736ba04c7732e?

MrGeorgen commented 2 years ago

still the same error

desbma commented 2 years ago

Are you sure your are testing the version from commit above?

File should be properly tagged now, despite your sample file having no tags at all initially:

$ r128gain /tmp/Leona\ Lewis\ -\ Bleeding\ Love\ \(Official\ Video\).aac
Unhandled or missing 'AAC' tag format for file '/tmp/Leona Lewis - Bleeding Love (Official Video).aac'
Analyzing loudness of file '/tmp/Leona Lewis - Bleeding Love (Official Video).aac'...
File '/tmp/Leona Lewis - Bleeding Love (Official Video).aac': loudness = -11.6 LUFS, sample peak = 0.0 dBFS
Tagging file '/tmp/Leona Lewis - Bleeding Love (Official Video).aac'
MrGeorgen commented 2 years ago

you are right, it works. I ran python r128gain in the directory of the git repo. While this uses the local __main.py__, it imported the old r128gain module I had installed. After reinstalling it, it worked. Thanks for your help and fix